Page MenuHomeFreeBSD
Differential D7788

net-p2p/gtk-gnutella: Update to 1.1.10
ClosedPublic
Actions

Authored by woodsb02 on Sep 5 2016, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:17 PM
Unknown Object (File)
Fri, Dec 20, 6:07 PM
Unknown Object (File)
Fri, Dec 20, 5:47 PM
Unknown Object (File)
Fri, Dec 20, 11:57 AM
Unknown Object (File)
Oct 18 2024, 12:40 AM
Unknown Object (File)
Oct 7 2024, 1:32 AM
Unknown Object (File)
Oct 5 2024, 1:03 AM
Unknown Object (File)
Oct 2 2024, 12:08 PM
View All Files
Subscribers
None

Details

Reviewers
adamw
koobs
mat
Commits
rP421430: net-p2p/gtk-gnutella: Update to 1.1.10
Summary

net-p2p/gtk-gnutella: Update to 1.1.10

  • Add undeclared dependencies detected by qa-stage script
Test Plan

poudriere testport: Test ok on 12amd64, 9i386, 9amd64
portlint: Looks ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5041
Build 5119: arc lint + arc unit

Event Timeline

woodsb02 updated this revision to Diff 20057.Sep 5 2016, 2:07 PM
woodsb02 retitled this revision from to net-p2p/gtk-gnutella: Update to 1.1.10.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, mat, koobs.
adamw accepted this revision.Sep 5 2016, 2:09 PM
adamw edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2016, 2:09 PM
mat added inline comments.Sep 5 2016, 2:21 PM
net-p2p/gtk-gnutella/Makefile
5–34

All this should be moved to a pkg-help file.

woodsb02 updated this revision to Diff 20069.Sep 5 2016, 11:48 PM
woodsb02 edited edge metadata.
  • Move text from Makefile to pkg-help
This revision now requires review to proceed.Sep 5 2016, 11:48 PM
woodsb02 marked an inline comment as done.Sep 6 2016, 12:04 AM
mat added inline comments.Sep 6 2016, 7:56 AM
net-p2p/gtk-gnutella/pkg-help
1 ↗(On Diff #20069)

This can be removed, as it is what pkg-help is. (If you've never seen one in use, it can be called up during "make config" with ^E or F1.)

woodsb02 updated this revision to Diff 20083.Sep 6 2016, 11:15 AM
woodsb02 edited edge metadata.
  • Remove note at the beginning of pkg-help
woodsb02 marked an inline comment as done.Sep 6 2016, 11:17 AM
woodsb02 added inline comments.
net-p2p/gtk-gnutella/pkg-help
1 ↗(On Diff #20069)

Thanks - I had never seen this before. It is not mentioned at all in the porter's handbook, but probably should be!

woodsb02 marked 2 inline comments as done.Sep 6 2016, 11:17 AM
mat accepted this revision.Sep 6 2016, 2:00 PM
mat edited edge metadata.

I think all those proxydeps should be fixed in USES=gnome, but it is a fight for another day.

This revision is now accepted and ready to land.Sep 6 2016, 2:00 PM
Closed by commit rP421430: net-p2p/gtk-gnutella: Update to 1.1.10 (authored by woodsb02). · Explain WhySep 6 2016, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
net-p2p/
gtk-gnutella/
7 lines
5 lines

Diff 20057

View Options

net-p2p/gtk-gnutella/Makefile

Loading...
View Options

net-p2p/gtk-gnutella/distinfo

Loading...
View Options

net-p2p/gtk-gnutella/files/

Loading...
View Options

net-p2p/gtk-gnutella/files/patch-src_gcc.h

Loading...