Differential D7670

Fix efi_cons_poll() when EFI implementation does not support WaitForKey
ClosedPublic
Actions

Authored by jmcneill on Aug 27 2016, 6:20 PM.

Details

Reviewers

imp

Group Reviewers

ARM

Commits

rS305026: When the EFI implementation (like U-Boot) does not support WaitForKey, we

Summary

When the EFI impl (like U-Boot) does not support WaitForKey, we can emulate efi_cons_poll() with a flag and caching the last key read with ReadKeyStroke. This fixes the loader.efi countdown timer on Pine64.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 19752.Aug 27 2016, 6:20 PM

jmcneill retitled this revision from to Fix efi_cons_poll() when EFI implementation does not support WaitForKey.

jmcneill updated this object.

jmcneill edited the test plan for this revision. (Show Details)

jmcneill added a reviewer: ARM.

jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.

jmcneill added projects: ARM, arm64.

Herald added a subscriber: imp. · View Herald TranscriptAug 27 2016, 6:20 PM

Haven't test yet but this looks good to me.

jmcneill added a reviewer: imp.Aug 29 2016, 6:45 PM

Looks like it should work regardless of where it is run...

This revision is now accepted and ready to land.Aug 29 2016, 6:58 PM

Closed by commit rS305026: When the EFI implementation (like U-Boot) does not support WaitForKey, we (authored by jmcneill). · Explain WhyAug 29 2016, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

libefi/

efi_console.c

36 lines

Diff 19801

View Options

head/sys/boot/efi/libefi/efi_console.c

Fix efi_cons_poll() when EFI implementation does not support WaitForKeyClosedPublicActions