Page MenuHomeFreeBSD
Differential D7663

Attach and LAW problems to fix
ClosedPublic
Actions

Authored by int0dster_gmail.com on Aug 26 2016, 4:44 PM.
Tags
Referenced Files
Unknown Object (File)
Apr 2 2024, 12:34 AM
Unknown Object (File)
Mar 13 2024, 8:03 AM
Unknown Object (File)
Dec 23 2023, 11:39 AM
Unknown Object (File)
Dec 22 2023, 2:13 PM
Unknown Object (File)
Dec 18 2023, 4:46 PM
Unknown Object (File)
Nov 2 2023, 8:04 PM
Unknown Object (File)
Sep 11 2023, 4:55 PM
Unknown Object (File)
Aug 15 2023, 12:28 PM
View All 20 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
nwhitehorn
jhibbits
marcel
Commits
rS305043: Attach and LAW problems to fix
Summary
  1. Attach problem - mpc85xx_probe() relies on fact that 0xfff0 mask

matches all QorIQ CPUs what is not true since e6500. This shall be reworked to match
against all supported CPUPs.

  1. IMO there is no any reason for operating system to re-program or anyhow else touch the LaWs programmed by

firmware (u-boot). Right now mpc85xx_attach() removes all LaW entries except for DRAM. This causes
MCE to be generated when later any of driver maps DTB-provided hardware addresses which do not exist
anymore because corresponding LaWs were removed.

Test Plan
  1. Build kernel
  2. Ensure that it boots all the way up to attempt of rootfs mount on t2080rdb board.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

int0dster_gmail.com updated this revision to Diff 19730.Aug 26 2016, 4:44 PM
int0dster_gmail.com retitled this revision from to Attach and LAW problems to fix.
int0dster_gmail.com updated this object.
int0dster_gmail.com edited the test plan for this revision. (Show Details)
int0dster_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
int0dster_gmail.com added a project: PowerPC.
Herald added a reviewer: jhibbits. · View Herald TranscriptAug 26 2016, 4:44 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
jhibbits edited edge metadata.Aug 26 2016, 5:16 PM

Adding a couple other reviewers. Looks fine to me, but summer may argue that the drivers should be responsible for the LAWs they use. I don't think Linux clears the windows, so I have no problem with the removal.

jhibbits added reviewers: nwhitehorn, marcel.Aug 26 2016, 5:18 PM
nwhitehorn edited edge metadata.Aug 29 2016, 7:06 PM

Looks Ok to me. Any idea why things were set up this way to begin with?

int0dster_gmail.com added a comment.EditedAug 29 2016, 7:30 PM
In D7663#159814, @nwhitehorn wrote:

Looks Ok to me. Any idea why things were set up this way to begin with?

No any specific ideas. May be those are leftovers from some contribution where they
got reprogrammed later, but these reprogramming bits were somehow missed.

jhibbits accepted this revision.Aug 29 2016, 7:50 PM
jhibbits edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2016, 7:50 PM
Closed by commit rS305043: Attach and LAW problems to fix (authored by jhibbits). · Explain WhyAug 30 2016, 2:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
powerpc/
mpc85xx/
33 lines

Diff 19812

View Options

head/sys/powerpc/mpc85xx/platform_mpc85xx.c

Loading...