Unlike Solaris, in FreeBSD p_args can be NULL so check for that before checking ar_args.

[markj]

cddl/lib/libdtrace/psinfo.d

63

You could squash this a bit: (T->p_args == 0 || T->p_args->ar_args == 0) ? "" : ...

The indentation looks a bit off too, but that might be phabricator.

[gnn]

Tighten up the logic.

[jhb]

I'm believe ar_args can't be NULL if p_args is non-NULL FWIW. Other places assume that ar_args is valid if p_args is not NULL. Given that, I think you can remove the ar_args check. Actually, ar_args isn't a pointer, it's a variable length array at the end of the structure, so there's never a pointer to check. You should remove the 'ar_args == 0' test.

[gnn]

jhb@ reports that if p_args is non 0 then ar_args will be valid.

[gnn]

Committed revision 304825.