Page MenuHomeFreeBSD
Differential D7646

ddb: Add 'show active trace' command
ClosedPublic
Actions

Authored by cem on Aug 25 2016, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 11:45 AM
Unknown Object (File)
Thu, Jan 9, 6:02 PM
Unknown Object (File)
Dec 3 2024, 7:43 PM
Unknown Object (File)
Nov 21 2024, 12:23 PM
Unknown Object (File)
Nov 17 2024, 12:29 PM
Unknown Object (File)
Nov 16 2024, 2:38 PM
Unknown Object (File)
Nov 10 2024, 1:36 PM
Unknown Object (File)
Nov 2 2024, 11:13 AM
View All 86 Files
Subscribers
imp

Details

Reviewers
jhb
mjg
Commits
rS304828: ddb: Add 'show active trace' command
Summary

'show active trace', or 'acttrace' for short, prints backtraces from running
threads only.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4936
Build 4999: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 19694.Aug 25 2016, 10:03 PM
cem retitled this revision from to ddb: Add 'show active trace' command.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: mjg, jhb.
Herald added a subscriber: imp. · View Herald TranscriptAug 25 2016, 10:03 PM
cem updated this revision to Diff 19695.Aug 25 2016, 10:15 PM

Reduce duplication between all trace and active trace implementations.

mjg added inline comments.Aug 26 2016, 1:24 AM
sys/ddb/db_command.c
837

I think it would be beneficial (apart from introduction the acctrace command) to extend the default output with cpu number, if given thread is running.

Other than that looks good to me, thanks.

cem added inline comments.Aug 26 2016, 1:38 AM
sys/ddb/db_command.c
837

The active_only (acttrace) output does include td_oncpu. It's the other clause of the if :-).

Or do you mean, I should add oncpu output to "all trace" as well?

mjg added inline comments.Aug 26 2016, 1:39 AM
sys/ddb/db_command.c
837

The latter.

mjg added inline comments.Aug 26 2016, 1:43 AM
sys/ddb/db_command.c
837

To be more specific, either only print CPU if the thread is running OR print CPU unconditionally along with the state, so that one can tell if it is on cpu (as opposed to having a note what last cpu it was on).

cem updated this revision to Diff 19705.Aug 26 2016, 1:45 AM

Print oncpu for running threads in both 'all trace' and 'active trace', per
mjg@.

cem marked an inline comment as done.Aug 26 2016, 1:46 AM

Does this look okay?

mjg accepted this revision.Aug 26 2016, 2:33 AM
mjg edited edge metadata.

LGTM, thanks

This revision is now accepted and ready to land.Aug 26 2016, 2:33 AM
Closed by commit rS304828: ddb: Add 'show active trace' command (authored by cem). · Explain WhyAug 26 2016, 2:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
ddb/
46 lines

Diff 19695

View Options

sys/ddb/db_command.c

Loading...