Rename sigprop-table constants to SIGPROP_ from SA_ to reduce the impression of a namespace collision.
ClosedPublic
Actions

Authored by brooks on Aug 23 2016, 5:44 PM.

Details

Reviewers

kib
jhb
rwatson

Commits

rS305288: Merge from CheriBSD:

Summary

Submitted by: rwatson
Sponsored by: DARAP, AFRL

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks updated this revision to Diff 19592.Aug 23 2016, 5:44 PM

brooks retitled this revision from to Rename sigprop-table constants to SIGPROP_ from SA_ to reduce the impression of a namespace collision..

brooks updated this object.

brooks edited the test plan for this revision. (Show Details)

brooks added reviewers: rwatson, jhb.

Herald added a subscriber: imp. · View Herald TranscriptAug 23 2016, 5:44 PM

Maybe see if kib@ cares. SIGPROP is a bit verbose, but a SP_ prefix probably implies "stack pointer" which is more confusing than SA_.

This revision is now accepted and ready to land.Aug 23 2016, 10:16 PM

brooks added a reviewer: kib.Aug 23 2016, 11:51 PM

I am curious why. Is the 'impression of collision' against the sigaction.sa_flags bits ?

sys/kern/kern_sig.c
199 ↗	(On Diff #19592)	Formatting there is completely broken. You left second tab after symbol names in all lines except TTYSTOP and IGNORE, and the look of the block is awful now. Also, most lines become too long.
3062 ↗	(On Diff #19592)	This line becames too long and must be wrapped.

Fix line wraps.

This revision now requires review to proceed.Aug 24 2016, 4:12 PM

The impression of collision is indeed with sigaction.sa_flags. In CheriBSD we expose signal properties to MD code so they appear near each other.

kib accepted this revision.Aug 24 2016, 9:19 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Aug 24 2016, 9:19 PM

kib added inline comments.Aug 24 2016, 9:21 PM

sys/kern/kern_sig.c
203 ↗	(On Diff #19644)	You may also use the opportunity to fix style in the table by adding spaces around '\|'.

Add spaces around |'s as suggested by kib.

This revision now requires review to proceed.Sep 2 2016, 4:13 PM

Made suggest style change.

kib accepted this revision.Sep 2 2016, 6:12 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Sep 2 2016, 6:12 PM

Closed by commit rS305288: Merge from CheriBSD: (authored by brooks). · Explain WhySep 2 2016, 6:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_sig.c

115 lines

Diff 19988

View Options

Rename sigprop-table constants to SIGPROP_ from SA_ to reduce the impression of a namespace collision.ClosedPublicActions