Update fusefs-lkl to recent version
ClosedPublic
Actions

Authored by cem on Aug 16 2016, 5:26 AM.

Details

Reviewers

bapt
bdrewery
mat

Commits

rP420357: sysutils/fusefs-lkl: Update to more recent master

Summary

Update fusefs-lkl from a 4.3.0 based master to more recent master.

This brings in support for extended filesystem options, needed for non-trivial
BTRFS configurations.

Test Plan

I successfully mounted an ext4 filesystem and manipulated files in it.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 19317.Aug 16 2016, 5:26 AM

cem retitled this revision from to Update fusefs-lkl to recent version.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: mat, bapt, bdrewery.

cem added inline comments.Aug 16 2016, 5:28 AM

sysutils/fusefs-lkl/files/patch-lib_Build
7–10 ↗	(On Diff #19317)	These use Linux-specific `epoll` and invoke Linux-specific `tun`/`tap` device configuration. I believe they could be ported to FreeBSD by a motivated individual somewhat familiar with `tun(4)`/`tap(4)`. They are not needed for `lklfuse`, so omitting them is fine for now IMO.
sysutils/fusefs-lkl/files/patch-lib_posix-host.c
7–18 ↗	(On Diff #19317)	These I intend to send upstream.

mat added inline comments.Aug 16 2016, 11:05 AM

sysutils/fusefs-lkl/Makefile
33 ↗	(On Diff #19317)	If this is so that it gets bc from its BUILD_DEPENDS, it should be LOCALBASE, not PREFIX.
44 ↗	(On Diff #19317)	This should be rephrased (11+), or the OSVERSION check changed, (1200000)

Fix bc/ld PATH and rephrase OSVERSION check now that CURRENT is 12.

Thanks!

Update to newer git master.

Remove patch-lib_posix-host.c, which has been upstreamed.

Looks good.

Maybe the OSVERSION check could be checked, 1100000 seems to be rather odd. it is what 11 was just after stable/10 was branched, so, 10 should work, but does not, so, I wonder if it should be changed to be the right one. See https://www.freebsd.org/doc/en/books/porters-handbook/versions.html for the list of all versions.

This revision is now accepted and ready to land.Aug 17 2016, 11:53 AM

Closed by commit rP420357: sysutils/fusefs-lkl: Update to more recent master (authored by cem). · Explain WhyAug 17 2016, 3:46 PM

This revision was automatically updated to reflect the committed changes.