Page MenuHomeFreeBSD
Differential D746

patch devel/orc to build on armv6 emulation
ClosedPublic
Actions

Authored by sbruno on Sep 9 2014, 6:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 5:26 PM
Unknown Object (File)
Jan 25 2024, 6:44 AM
Unknown Object (File)
Jan 13 2024, 10:46 AM
Unknown Object (File)
Dec 26 2023, 9:13 AM
Unknown Object (File)
Dec 23 2023, 9:17 PM
Unknown Object (File)
Dec 22 2023, 2:27 AM
Unknown Object (File)
Oct 30 2023, 6:42 PM
Unknown Object (File)
Oct 28 2023, 3:36 PM
View All 63 Files
Subscribers
sson

Details

Reviewers
bapt
kwm
bdrewery
Summary

there's a bug in qemu-arm float emulation causing the build
of devel/orc to fail, but the code itself is sort of wrong too.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sbruno updated this revision to Diff 1415.Sep 9 2014, 6:39 AM
sbruno retitled this revision from to patch devel/orc to build on armv6 emulation.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added a reviewer: kwm.
sbruno added a subscriber: sson.
sbruno added a comment.Sep 9 2014, 6:40 AM

https://redports.org/buildarchive/20140909063100-20757/

seems happy on redports

sbruno added reviewers: bapt, bdrewery.Sep 10 2014, 4:16 PM
bdrewery edited edge metadata.Sep 11 2014, 11:21 PM

Do you have a build log for this one with the failure?

sbruno added a comment.Sep 11 2014, 11:39 PM

but of course:

http://chips.ysv.freebsd.org/data/11armv632-default/2014-09-04_01h04m05s/logs/errors/orc-0.4.21.log

Now, understand that this will actually *not* happen on REAL hardware. This is a very nasty, undebugged failure of our qemu-emulation.

But, this is sort of a bug in the code too. So ... its arguable.

kwm requested changes to this revision.Sep 16 2014, 6:08 AM
kwm edited edge metadata.
kwm added inline comments.
devel/orc/files/patch-orc-orcprogram-c.c
2

Could you put some text above the --- orc/orcprogram-c.c.orig line explaining why this patch is needed? Like you stated it is to work around a qemu problem.

This revision now requires changes to proceed.Sep 16 2014, 6:08 AM
sbruno updated this revision to Diff 1640.Sep 16 2014, 12:15 PM
sbruno edited edge metadata.

Update patch file with some comments as to why this patch is being applied.

kwm accepted this revision.Sep 16 2014, 12:24 PM
kwm edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2014, 12:24 PM
bapt accepted this revision.Sep 16 2014, 12:31 PM
bapt edited edge metadata.
sbruno closed this revision.Sep 16 2014, 12:40 PM

Committed at svn r368308.

Revision Contents
Changeset List

PathSize
devel/
orc/
files/
15 lines

Diff 1640

View Options

devel/orc/files/patch-orc-orcprogram-c.c

Loading...