Josh Ruehlig proposed the following patch:
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172811&action=diff
I'm no ports committer, so I need review and then approval.
Thanks!
- Jeremie
Details
Details
- Reviewers
crees - Group Reviewers
Ports Committers - Commits
- rP420615: Minor improvements.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| subsonic-standalone/Makefile | ||
|---|---|---|
| 77–79 ↗ | (On Diff #18728) | This can now be in a post-install-FFMPEG-on: target rather than having an .if check. Same for the lower checks as well. |
Comment Actions
@bdrewery, so lines 77-85 should be replaced with the following. Anything else that needs to be done to get this committed?
post-install-FFMPEG-on:
${LN} -sf ${PREFIX}/bin/ffmpeg ${STAGEDIR}${SUBSONIC_HOME}/transcode/ffmpeg
post-install-FLAC-on:
${LN} -sf ${PREFIX}/bin/flac ${STAGEDIR}${SUBSONIC_HOME}/transcode/flac
post-install-LAME-on:
${LN} -sf ${PREFIX}/bin/lame ${STAGEDIR}${SUBSONIC_HOME}/transcode/lameComment Actions
Please see my inline comments, but if mine and Bryan's are followed, please consider it approved by me.
Cheers!
| subsonic-standalone/Makefile | ||
|---|---|---|
| 9 ↗ | (On Diff #18728) | I think this change is wrong, and it should indeed be called subsonic-standalone PORTNAME, and the DISTNAME put back to how it was. The whole point of PKGNAMESUFFIX is to have a FreeBSD suffix without messing up DISTNAME! |
| subsonic-standalone/pkg-plist | ||
| 7 ↗ | (On Diff #18728) | This needs || true adding to the end of the line, otherwise pkg will think it's an error if the directory doesn't exist. There should have been one on the previous revision! |
Comment Actions
Sorry, I see why your PKGNAMESUFFIX change was made. I don't have strong feelings on it, so I'll leave it up to you :)
| subsonic-standalone/Makefile | ||
|---|---|---|
| 9 ↗ | (On Diff #18728) | Ah, I see why you've done that, as DISTNAME is weird... I still prefer the previous version. |