Page MenuHomeFreeBSD

Improvements for www/madsonic-standalone (Bug 210651)
ClosedPublic

Authored by jlh on Jul 25 2016, 9:49 AM.
Tags
None
Referenced Files
F83178653: D7305.diff
Tue, May 7, 8:40 AM
Unknown Object (File)
Fri, Apr 26, 9:45 AM
Unknown Object (File)
Fri, Apr 26, 9:45 AM
Unknown Object (File)
Fri, Apr 26, 9:45 AM
Unknown Object (File)
Fri, Apr 26, 9:44 AM
Unknown Object (File)
Fri, Apr 26, 2:32 AM
Unknown Object (File)
Mar 11 2024, 6:46 AM
Unknown Object (File)
Feb 21 2024, 3:34 AM

Details

Reviewers
crees
Group Reviewers
Ports Committers
Commits
rP420614: Minor improvements.
Summary

Josh Ruehlig proposed the following patch:
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172812&action=diff

I'm no ports committer, so I need review and then approval.

NOTE: this is very similar to https://reviews.freebsd.org/D7304

Thanks!

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jlh retitled this revision from to Improvements for www/madsonic-standalone (Bug 210651).
jlh updated this object.
jlh edited the test plan for this revision. (Show Details)
jlh added a reviewer: Ports Committers.
jlh set the repository for this revision to rP FreeBSD ports repository.

Lines 82-90 should be replaced with the following...

post-install-FFMPEG-on:
	${LN} -sf ${PREFIX}/bin/ffmpeg ${STAGEDIR}${SUBSONIC_HOME}/transcode/ffmpeg

post-install-FLAC-on:
	${LN} -sf ${PREFIX}/bin/flac ${STAGEDIR}${SUBSONIC_HOME}/transcode/flac

post-install-LAME-on:
	${LN} -sf ${PREFIX}/bin/lame ${STAGEDIR}${SUBSONIC_HOME}/transcode/lame
crees added a reviewer: crees.
crees added a subscriber: crees.

Please see notes, but approved.

Cheers!

Chris

madsonic-standalone/pkg-plist
6 ↗(On Diff #18729)

Please add

|| true

to the end of this line, as explained in D7304

This revision is now accepted and ready to land.Aug 11 2016, 8:12 PM
jlh edited edge metadata.
jlh marked an inline comment as done.

Comments fulfilled.

This revision now requires review to proceed.Aug 16 2016, 8:38 PM
crees edited edge metadata.

Great, please commit.

This revision is now accepted and ready to land.Aug 16 2016, 9:29 PM
This revision was automatically updated to reflect the committed changes.