deskutils/xfce4-notification-daemon: Mark DEPRECATED

[woodsb02]

Summary

deskutils/xfce4-notification-daemon: Mark DEPRECATED

No longer maintained upstream, replaced by deskutils/xfce4-notifyd

Additionally deprecated by USE_XFCE=libgui [1]

[1] https://svnweb.freebsd.org/ports/head/Mk/Uses/xfce.mk?revision=411970

Approved by: ehaupt (maintainer)
Approved by: foo (mentor)
DiffRev: DXXX

Based on feedback from olivierd here:
https://reviews.freebsd.org/D6981#inline-43292

Test Plan

• portlint: result TBA
• testport: result TBA
• make -VDEPRECATED -VEXPIRATION_DATE:

[woodsb02]

olivierd - what are your thoughts on deprecating deskutils/xfce4-notification-daemon?

[olivierd]

Why to accept this changes, without informed the maintainer (ehaupt)?

[mat]

In D7199#173225, @olivierd wrote:

Why to accept this changes, without informed the maintainer (ehaupt)?

I accepted the change as Ben's mentor.

[woodsb02]

ehaupt: What do you think about marking deskutils/xfce4-notification-daemon as deprecated and then removing it from ports 1 month later? My understanding is that it is no longer maintained and is fully replaced by deskutils/xfce4-notifyd?

It is also worth noting that deskutils/xfce4-notification-daemon is already marked deprecated due to USE_XFCE=libgui:
https://svnweb.freebsd.org/ports/head/Mk/Uses/xfce.mk?revision=411970&view=markup#l101

[koobs]

@woodsb02 Please use the SUMMARY field as the proposed commit log (i've updated it this time to provide example).

Besides ensuring all relevant context is included at review time without having to hunt in comments or elsewhere, it also ensures this context is included in the commit log message itself (as it should), and makes approval requirements and other commit log metadata (and your understanding of it) explicit.

[koobs]

Please also include test results in the test plan section, not just a description/list of what will/has been run

[ehaupt]

In D7199#173297, @woodsb02 wrote:

ehaupt: What do you think about marking deskutils/xfce4-notification-daemon as deprecated and then removing it from ports 1 month later? My understanding is that it is no longer maintained and is fully replaced by deskutils/xfce4-notifyd?

It is also worth noting that deskutils/xfce4-notification-daemon is already marked deprecated due to USE_XFCE=libgui:
https://svnweb.freebsd.org/ports/head/Mk/Uses/xfce.mk?revision=411970&view=markup#l101

At this point deprecating the port makes sense. As maintainer I approve this change.