Update llvm-libunwind to new version imported in rS302347
ClosedPublic
Actions

Authored by emaste on Jul 5 2016, 9:10 PM.

Details

Reviewers

andrew
br

Commits

rS302450: libunwind: update to upstream snapshot r272680

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 18166.Jul 5 2016, 9:10 PM

emaste retitled this revision from to Update llvm-libunwind to new version imported in rS302347.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: br, andrew.

emaste added a subscriber: dim.

emaste added inline comments.Jul 5 2016, 9:21 PM

contrib/llvm/projects/libunwind/include/__libunwind_config.h
20	Need to enable this by default, perhaps just by `#define _LIBUNWIND_IS_NATIVE_ONLY` in this file.
45	Need `_LIBUNWIND_CONTEXT_SIZE` and `_LIBUNWIND_CURSOR_SIZE` for RISC-V.
contrib/llvm/projects/libunwind/src/Registers.hpp
1073–1074	Needs update to match the other architectures: see http://reviews.llvm.org/rL270692

Do we use this on RISC-V? I see there is a TODO at the bottom of UnwindRegistersSave.S to implement the needed asm function(s).

contrib/llvm/projects/libunwind/include/__libunwind_config.h
20	Or add `CFLAGS+=-D_LIBUNWIND_IS_NATIVE_ONLY` to the Makefile.
45	Do we know the RISC-V sizes?

In D7123#148722, @andrew wrote:

Do we use this on RISC-V? I see there is a TODO at the bottom of UnwindRegistersSave.S to implement the needed asm function(s).

We build it as a stub on RISC-V now, but clearly it does not actually work there yet.

emaste added inline comments.Jul 6 2016, 6:28 PM

contrib/llvm/projects/libunwind/include/__libunwind_config.h
20	Yeah, that's a better approach as it will allow us to move to a completely unmodified version in the future.
45	We can be safe by using the max sizes for now: # define _LIBUNWIND_CONTEXT_SIZE 128 # define _LIBUNWIND_CURSOR_SIZE 140