Add timer_settime tests using SIGEV_THREAD.

[jhb]

Summary

Add timer_settime tests using SIGEV_THREAD.

I'm not sure if it's better to commit this to the NetBSD test directly
or if we should add a FreeBSD-specific test file in src/lib/librt/tests.
The tests themselves should be POSIX and run fine on NetBSD in theory.

Test Plan

• I ran one of these tests under gdb to test a patch to gdb to pass SIGLIBRT through to processes transparently by default (SIGEV_THREAD uses SIGLIBRT under the covers).

[ngie]

Please add

#ifdef __FreeBSD__

around all FreeBSD specific changes.

I think contrib/netbsd-tests is due for a refresh. I'll do that in the upcoming weeks/couple months. Anything annotated will help me when doing that work.

[ngie]

Is this sensitive to wall clock time? The reason why I ask is that we run these tests on real hardware and virtual hardware at $work, and sometimes we'd run into spurious test failures with virtual hardware if the invariants checking was too pedantic, because the clock had "tocked".

contrib/netbsd-tests/lib/libc/sys/t_timer_create.c

159 ↗

(On Diff #18163)

Why 2 seconds? What if this returns early?

[jhb]

In D7121#149375, @ngie wrote:

Please add

#ifdef __FreeBSD__

around all FreeBSD specific changes.

I think contrib/netbsd-tests is due for a refresh. I'll do that in the upcoming weeks/couple months. Anything annotated will help me when doing that work.

SIGEV_THREAD is in POSIX, so these should work fine on NetBSD as well.

[jhb]

In D7121#149376, @ngie wrote:

Is this sensitive to wall clock time? The reason why I ask is that we run these tests on real hardware and virtual hardware at $work, and sometimes we'd run into spurious test failures with virtual hardware if the invariants checking was too pedantic, because the clock had "tocked".

It is copy and pasted from the other tests. It should be no more broken than they are.

contrib/netbsd-tests/lib/libc/sys/t_timer_create.c

159 ↗

(On Diff #18163)

It is copied from timer_signal_create().

[jhb]

Ping?

[ngie]

In D7121#153095, @jhb wrote:

Ping?

Please add the #ifdef __FreeBSD__ blocks around new code introduced in FreeBSD. I'll work on "upstreaming" code soon to NetBSD from contrib/netbsd-tests -- adding #ifdef __(FreeBSD|NetBSD)__ makes it easier for me to discern code that needs to be merged from any incoming code.

contrib/netbsd-tests/lib/libc/sys/t_timer_create.c

159 ↗

(On Diff #18163)

Ok.

[jhb]

Ah, it wasn't clear to me that you wanted #ifdef's around code that was applicable to NetBSD. I had assumed we only wanted that for tests that only ran on FreeBSD and were not applicable to NetBSD.

[ngie]

In D7121#153124, @jhb wrote:

Ah, it wasn't clear to me that you wanted #ifdef's around code that was applicable to NetBSD. I had assumed we only wanted that for tests that only ran on FreeBSD and were not applicable to NetBSD.

The general rule of thumb is:

• __FreeBSD__: for FreeBSD; potentially upstreamable to NetBSD.
• __NetBSD__: for NetBSD only (for features not available in FreeBSD, or behavior specific to NetBSD)

[jhb]

• Add FreeBSD guards.