Page MenuHomeFreeBSD
Differential D7110

hyperv/vmbus: Release vmbus channel lock before detach devices
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jul 5 2016, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 1:46 PM
Unknown Object (File)
Sun, Mar 9, 9:13 PM
Unknown Object (File)
Feb 23 2025, 2:49 PM
Unknown Object (File)
Feb 4 2025, 10:09 PM
Unknown Object (File)
Jan 30 2025, 6:30 AM
Unknown Object (File)
Jan 27 2025, 2:07 AM
Unknown Object (File)
Jan 15 2025, 11:53 PM
Unknown Object (File)
Jan 3 2025, 8:10 PM
View All 56 Files
Subscribers
None

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS302816: hyperv/vmbus: Release vmbus channel lock before detach devices
Summary
Device detach method may sleep.

While I'm here, rename the function, fix indentation and function
comment.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 18147.Jul 5 2016, 1:48 PM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Release vmbus channel lock before detach devices.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
Closed by commit rS302816: hyperv/vmbus: Release vmbus channel lock before detach devices (authored by sephe). · Explain WhyJul 14 2016, 7:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
vmbus/
22 lines
3 lines
2 lines
1 line

Diff 18415

View Options

head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Show All 27 Lines
options KERNVIRTADDR=0xc0000000 options KERNVIRTADDR=0xc0000000
include "std.armv6" include "std.armv6"
files "../allwinner/files.allwinner" files "../allwinner/files.allwinner"
files "../allwinner/a20/files.a20" files "../allwinner/a20/files.a20"
files "../allwinner/a31/files.a31" files "../allwinner/a31/files.a31"
files "../allwinner/a83t/files.a83t" files "../allwinner/a83t/files.a83t"
files "../allwinner/h3/files.h3" files "../allwinner/h3/files.h3"
files "../nvidia/tegra124/files.tegra124"
files "../qemu/files.qemu" files "../qemu/files.qemu"
options SOC_ALLWINNER_A20 options SOC_ALLWINNER_A20
options SOC_ALLWINNER_A31 options SOC_ALLWINNER_A31
options SOC_ALLWINNER_A31S options SOC_ALLWINNER_A31S
options SOC_ALLWINNER_A83T options SOC_ALLWINNER_A83T
options SOC_ALLWINNER_H3 options SOC_ALLWINNER_H3
options SCHED_ULE # ULE scheduler options SCHED_ULE # ULE scheduler
options SMP # Enable multiple cores options SMP # Enable multiple cores
options PLATFORM options PLATFORM
options PLATFORM_SMP options PLATFORM_SMP
options MULTIDELAY options MULTIDELAY
options LINUX_BOOT_ABI
# EXT_RESOURCES pseudo devices # EXT_RESOURCES pseudo devices
options EXT_RESOURCES options EXT_RESOURCES
device clk device clk
device phy device phy
device hwreset device hwreset
device regulator device regulator
# Interrupt controller # Interrupt controller
options INTRNG options INTRNG
device gic device gic
# ARM Generic Timer # ARM Generic Timer
device generic_timer device generic_timer
# MMC/SD/SDIO Card slot support # MMC/SD/SDIO Card slot support
device sdhci # SD controller
device mmc # mmc/sd bus device mmc # mmc/sd bus
device mmcsd # mmc/sd flash cards device mmcsd # mmc/sd flash cards
# ATA controllers # ATA controllers
device ahci # AHCI-compatible SATA controllers device ahci # AHCI-compatible SATA controllers
#device ata # Legacy ATA/SATA controllers #device ata # Legacy ATA/SATA controllers
# PCI
options NEW_PCIB
device pci
# PCI NICs
device re # RealTek 8139C+/8169/8169S/8110S
# VirtIO # VirtIO
device virtio device virtio
device virtio_mmio device virtio_mmio
device virtio_blk device virtio_blk
device vtnet device vtnet
# Console and misc # Console and misc
device uart device uart
device uart_ns8250
device uart_snps device uart_snps
device pl011 device pl011
device pty device pty
device snp device snp
device md device md # Memory "disks"
device random # Entropy device device random # Entropy device
device psci device psci
# I2C support # I2C support
device iicbus device iicbus
device iic device iic
device twsi device twsi
device rsb device rsb
device axp209 # AXP209 Power Management Unit device axp209 # AXP209 Power Management Unit
device axp81x # AXP813/818 Power Management Unit device axp81x # AXP813/818 Power Management Unit
device icee
# GPIO # GPIO
device gpio device gpio
device gpioled device gpioled
device scbus # SCSI bus (required for ATA/SCSI) device scbus # SCSI bus (required for ATA/SCSI)
device da # Direct Access (disks) device da # Direct Access (disks)
device cd # CD
device pass # Passthrough device (direct ATA/SCSI access) device pass # Passthrough device (direct ATA/SCSI access)
# USB support # USB support
options USB_HOST_ALIGN=64 # Align usb buffers to cache line size. options USB_HOST_ALIGN=64 # Align usb buffers to cache line size.
device usb device usb
#device uhci #device uhci
device ohci device ohci
device ehci device ehci
device umass device umass # Disks/Mass storage - Requires scbus and da
device uhid # "Human Interface Devices"
device ukbd # Allow keyboard like HIDs to control console
# Ethernet # Ethernet
device loop device loop
device ether device ether
device vlan # 802.1Q VLAN support
device mii device mii
device bpf device bpf
#device emac # 10/100 integrated EMAC controller #device emac # 10/100 integrated EMAC controller
device dwc # 10/100/1000 integrated GMAC controller device dwc # 10/100/1000 integrated GMAC controller
device awg # 10/100/1000 integrated EMAC controller device awg # 10/100/1000 integrated EMAC controller
# USB ethernet support, requires miibus # USB ethernet support, requires miibus
Show All 22 Lines
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_priv.h

Show All 27 Lines
options KERNVIRTADDR=0xc0000000 options KERNVIRTADDR=0xc0000000
include "std.armv6" include "std.armv6"
files "../allwinner/files.allwinner" files "../allwinner/files.allwinner"
files "../allwinner/a20/files.a20" files "../allwinner/a20/files.a20"
files "../allwinner/a31/files.a31" files "../allwinner/a31/files.a31"
files "../allwinner/a83t/files.a83t" files "../allwinner/a83t/files.a83t"
files "../allwinner/h3/files.h3" files "../allwinner/h3/files.h3"
files "../nvidia/tegra124/files.tegra124"
files "../qemu/files.qemu" files "../qemu/files.qemu"
options SOC_ALLWINNER_A20 options SOC_ALLWINNER_A20
options SOC_ALLWINNER_A31 options SOC_ALLWINNER_A31
options SOC_ALLWINNER_A31S options SOC_ALLWINNER_A31S
options SOC_ALLWINNER_A83T options SOC_ALLWINNER_A83T
options SOC_ALLWINNER_H3 options SOC_ALLWINNER_H3
options SCHED_ULE # ULE scheduler options SCHED_ULE # ULE scheduler
options SMP # Enable multiple cores options SMP # Enable multiple cores
options PLATFORM options PLATFORM
options PLATFORM_SMP options PLATFORM_SMP
options MULTIDELAY options MULTIDELAY
options LINUX_BOOT_ABI
# EXT_RESOURCES pseudo devices # EXT_RESOURCES pseudo devices
options EXT_RESOURCES options EXT_RESOURCES
device clk device clk
device phy device phy
device hwreset device hwreset
device regulator device regulator
# Interrupt controller # Interrupt controller
options INTRNG options INTRNG
device gic device gic
# ARM Generic Timer # ARM Generic Timer
device generic_timer device generic_timer
# MMC/SD/SDIO Card slot support # MMC/SD/SDIO Card slot support
device sdhci # SD controller
device mmc # mmc/sd bus device mmc # mmc/sd bus
device mmcsd # mmc/sd flash cards device mmcsd # mmc/sd flash cards
# ATA controllers # ATA controllers
device ahci # AHCI-compatible SATA controllers device ahci # AHCI-compatible SATA controllers
#device ata # Legacy ATA/SATA controllers #device ata # Legacy ATA/SATA controllers
# PCI
options NEW_PCIB
device pci
# PCI NICs
device re # RealTek 8139C+/8169/8169S/8110S
# VirtIO # VirtIO
device virtio device virtio
device virtio_mmio device virtio_mmio
device virtio_blk device virtio_blk
device vtnet device vtnet
# Console and misc # Console and misc
device uart device uart
device uart_ns8250
device uart_snps device uart_snps
device pl011 device pl011
device pty device pty
device snp device snp
device md device md # Memory "disks"
device random # Entropy device device random # Entropy device
device psci device psci
# I2C support # I2C support
device iicbus device iicbus
device iic device iic
device twsi device twsi
device rsb device rsb
device axp209 # AXP209 Power Management Unit device axp209 # AXP209 Power Management Unit
device axp81x # AXP813/818 Power Management Unit device axp81x # AXP813/818 Power Management Unit
device icee
# GPIO # GPIO
device gpio device gpio
device gpioled device gpioled
device scbus # SCSI bus (required for ATA/SCSI) device scbus # SCSI bus (required for ATA/SCSI)
device da # Direct Access (disks) device da # Direct Access (disks)
device cd # CD
device pass # Passthrough device (direct ATA/SCSI access) device pass # Passthrough device (direct ATA/SCSI access)
# USB support # USB support
options USB_HOST_ALIGN=64 # Align usb buffers to cache line size. options USB_HOST_ALIGN=64 # Align usb buffers to cache line size.
device usb device usb
#device uhci #device uhci
device ohci device ohci
device ehci device ehci
device umass device umass # Disks/Mass storage - Requires scbus and da
device uhid # "Human Interface Devices"
device ukbd # Allow keyboard like HIDs to control console
# Ethernet # Ethernet
device loop device loop
device ether device ether
device vlan # 802.1Q VLAN support
device mii device mii
device bpf device bpf
#device emac # 10/100 integrated EMAC controller #device emac # 10/100 integrated EMAC controller
device dwc # 10/100/1000 integrated GMAC controller device dwc # 10/100/1000 integrated GMAC controller
device awg # 10/100/1000 integrated EMAC controller device awg # 10/100/1000 integrated EMAC controller
# USB ethernet support, requires miibus # USB ethernet support, requires miibus
Show All 22 Lines
View Options

head/sys/dev/hyperv/vmbus/vmbus.c

Show All 27 Lines
options KERNVIRTADDR=0xc0000000 options KERNVIRTADDR=0xc0000000
include "std.armv6" include "std.armv6"
files "../allwinner/files.allwinner" files "../allwinner/files.allwinner"
files "../allwinner/a20/files.a20" files "../allwinner/a20/files.a20"
files "../allwinner/a31/files.a31" files "../allwinner/a31/files.a31"
files "../allwinner/a83t/files.a83t" files "../allwinner/a83t/files.a83t"
files "../allwinner/h3/files.h3" files "../allwinner/h3/files.h3"
files "../nvidia/tegra124/files.tegra124"
files "../qemu/files.qemu" files "../qemu/files.qemu"
options SOC_ALLWINNER_A20 options SOC_ALLWINNER_A20
options SOC_ALLWINNER_A31 options SOC_ALLWINNER_A31
options SOC_ALLWINNER_A31S options SOC_ALLWINNER_A31S
options SOC_ALLWINNER_A83T options SOC_ALLWINNER_A83T
options SOC_ALLWINNER_H3 options SOC_ALLWINNER_H3
options SCHED_ULE # ULE scheduler options SCHED_ULE # ULE scheduler
options SMP # Enable multiple cores options SMP # Enable multiple cores
options PLATFORM options PLATFORM
options PLATFORM_SMP options PLATFORM_SMP
options MULTIDELAY options MULTIDELAY
options LINUX_BOOT_ABI
# EXT_RESOURCES pseudo devices # EXT_RESOURCES pseudo devices
options EXT_RESOURCES options EXT_RESOURCES
device clk device clk
device phy device phy
device hwreset device hwreset
device regulator device regulator
# Interrupt controller # Interrupt controller
options INTRNG options INTRNG
device gic device gic
# ARM Generic Timer # ARM Generic Timer
device generic_timer device generic_timer
# MMC/SD/SDIO Card slot support # MMC/SD/SDIO Card slot support
device sdhci # SD controller
device mmc # mmc/sd bus device mmc # mmc/sd bus
device mmcsd # mmc/sd flash cards device mmcsd # mmc/sd flash cards
# ATA controllers # ATA controllers
device ahci # AHCI-compatible SATA controllers device ahci # AHCI-compatible SATA controllers
#device ata # Legacy ATA/SATA controllers #device ata # Legacy ATA/SATA controllers
# PCI
options NEW_PCIB
device pci
# PCI NICs
device re # RealTek 8139C+/8169/8169S/8110S
# VirtIO # VirtIO
device virtio device virtio
device virtio_mmio device virtio_mmio
device virtio_blk device virtio_blk
device vtnet device vtnet
# Console and misc # Console and misc
device uart device uart
device uart_ns8250
device uart_snps device uart_snps
device pl011 device pl011
device pty device pty
device snp device snp
device md device md # Memory "disks"
device random # Entropy device device random # Entropy device
device psci device psci
# I2C support # I2C support
device iicbus device iicbus
device iic device iic
device twsi device twsi
device rsb device rsb
device axp209 # AXP209 Power Management Unit device axp209 # AXP209 Power Management Unit
device axp81x # AXP813/818 Power Management Unit device axp81x # AXP813/818 Power Management Unit
device icee
# GPIO # GPIO
device gpio device gpio
device gpioled device gpioled
device scbus # SCSI bus (required for ATA/SCSI) device scbus # SCSI bus (required for ATA/SCSI)
device da # Direct Access (disks) device da # Direct Access (disks)
device cd # CD
device pass # Passthrough device (direct ATA/SCSI access) device pass # Passthrough device (direct ATA/SCSI access)
# USB support # USB support
options USB_HOST_ALIGN=64 # Align usb buffers to cache line size. options USB_HOST_ALIGN=64 # Align usb buffers to cache line size.
device usb device usb
#device uhci #device uhci
device ohci device ohci
device ehci device ehci
device umass device umass # Disks/Mass storage - Requires scbus and da
device uhid # "Human Interface Devices"
device ukbd # Allow keyboard like HIDs to control console
# Ethernet # Ethernet
device loop device loop
device ether device ether
device vlan # 802.1Q VLAN support
device mii device mii
device bpf device bpf
#device emac # 10/100 integrated EMAC controller #device emac # 10/100 integrated EMAC controller
device dwc # 10/100/1000 integrated GMAC controller device dwc # 10/100/1000 integrated GMAC controller
device awg # 10/100/1000 integrated EMAC controller device awg # 10/100/1000 integrated EMAC controller
# USB ethernet support, requires miibus # USB ethernet support, requires miibus
Show All 22 Lines
View Options

head/sys/dev/hyperv/vmbus/vmbus_var.h

Show All 27 Lines
options KERNVIRTADDR=0xc0000000 options KERNVIRTADDR=0xc0000000
include "std.armv6" include "std.armv6"
files "../allwinner/files.allwinner" files "../allwinner/files.allwinner"
files "../allwinner/a20/files.a20" files "../allwinner/a20/files.a20"
files "../allwinner/a31/files.a31" files "../allwinner/a31/files.a31"
files "../allwinner/a83t/files.a83t" files "../allwinner/a83t/files.a83t"
files "../allwinner/h3/files.h3" files "../allwinner/h3/files.h3"
files "../nvidia/tegra124/files.tegra124"
files "../qemu/files.qemu" files "../qemu/files.qemu"
options SOC_ALLWINNER_A20 options SOC_ALLWINNER_A20
options SOC_ALLWINNER_A31 options SOC_ALLWINNER_A31
options SOC_ALLWINNER_A31S options SOC_ALLWINNER_A31S
options SOC_ALLWINNER_A83T options SOC_ALLWINNER_A83T
options SOC_ALLWINNER_H3 options SOC_ALLWINNER_H3
options SCHED_ULE # ULE scheduler options SCHED_ULE # ULE scheduler
options SMP # Enable multiple cores options SMP # Enable multiple cores
options PLATFORM options PLATFORM
options PLATFORM_SMP options PLATFORM_SMP
options MULTIDELAY options MULTIDELAY
options LINUX_BOOT_ABI
# EXT_RESOURCES pseudo devices # EXT_RESOURCES pseudo devices
options EXT_RESOURCES options EXT_RESOURCES
device clk device clk
device phy device phy
device hwreset device hwreset
device regulator device regulator
# Interrupt controller # Interrupt controller
options INTRNG options INTRNG
device gic device gic
# ARM Generic Timer # ARM Generic Timer
device generic_timer device generic_timer
# MMC/SD/SDIO Card slot support # MMC/SD/SDIO Card slot support
device sdhci # SD controller
device mmc # mmc/sd bus device mmc # mmc/sd bus
device mmcsd # mmc/sd flash cards device mmcsd # mmc/sd flash cards
# ATA controllers # ATA controllers
device ahci # AHCI-compatible SATA controllers device ahci # AHCI-compatible SATA controllers
#device ata # Legacy ATA/SATA controllers #device ata # Legacy ATA/SATA controllers
# PCI
options NEW_PCIB
device pci
# PCI NICs
device re # RealTek 8139C+/8169/8169S/8110S
# VirtIO # VirtIO
device virtio device virtio
device virtio_mmio device virtio_mmio
device virtio_blk device virtio_blk
device vtnet device vtnet
# Console and misc # Console and misc
device uart device uart
device uart_ns8250
device uart_snps device uart_snps
device pl011 device pl011
device pty device pty
device snp device snp
device md device md # Memory "disks"
device random # Entropy device device random # Entropy device
device psci device psci
# I2C support # I2C support
device iicbus device iicbus
device iic device iic
device twsi device twsi
device rsb device rsb
device axp209 # AXP209 Power Management Unit device axp209 # AXP209 Power Management Unit
device axp81x # AXP813/818 Power Management Unit device axp81x # AXP813/818 Power Management Unit
device icee
# GPIO # GPIO
device gpio device gpio
device gpioled device gpioled
device scbus # SCSI bus (required for ATA/SCSI) device scbus # SCSI bus (required for ATA/SCSI)
device da # Direct Access (disks) device da # Direct Access (disks)
device cd # CD
device pass # Passthrough device (direct ATA/SCSI access) device pass # Passthrough device (direct ATA/SCSI access)
# USB support # USB support
options USB_HOST_ALIGN=64 # Align usb buffers to cache line size. options USB_HOST_ALIGN=64 # Align usb buffers to cache line size.
device usb device usb
#device uhci #device uhci
device ohci device ohci
device ehci device ehci
device umass device umass # Disks/Mass storage - Requires scbus and da
device uhid # "Human Interface Devices"
device ukbd # Allow keyboard like HIDs to control console
# Ethernet # Ethernet
device loop device loop
device ether device ether
device vlan # 802.1Q VLAN support
device mii device mii
device bpf device bpf
#device emac # 10/100 integrated EMAC controller #device emac # 10/100 integrated EMAC controller
device dwc # 10/100/1000 integrated GMAC controller device dwc # 10/100/1000 integrated GMAC controller
device awg # 10/100/1000 integrated EMAC controller device awg # 10/100/1000 integrated EMAC controller
# USB ethernet support, requires miibus # USB ethernet support, requires miibus
Show All 22 Lines