Page MenuHomeFreeBSD

Remove support for pkg_install
ClosedPublic

Authored by bapt on Sep 1 2014, 6:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 11:28 AM
Unknown Object (File)
Jan 21 2024, 7:38 AM
Unknown Object (File)
Jan 3 2024, 10:57 AM
Unknown Object (File)
Dec 17 2023, 2:08 AM
Unknown Object (File)
Nov 26 2023, 4:52 PM
Unknown Object (File)
Nov 23 2023, 1:54 AM
Unknown Object (File)
Nov 21 2023, 12:04 PM
Unknown Object (File)
Nov 21 2023, 8:41 AM
Subscribers

Details

Reviewers
antoine
bdrewery
Group Reviewers
portmgr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bapt retitled this revision from to Remove support for pkg_install.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: portmgr.
bapt edited edge metadata.

Small fixes

antoine added inline comments.
net-mgmt/nagios-check_ports/Makefile
19โ€“20

should be removed?

Mk/bsd.port.mk
1706

strange . here

a few lines from devel/pear/bsd.pear.mk can be removed too

Add a note about WITH_PKG

mat added inline comments.
Mk/bsd.port.mk
1602

Mmm, is @stopdaemon included in pkg ?

net-mgmt/nagios-check_ports/Makefile
19โ€“20

I think that one is wrong, the dependency on portaudit should be removed completely.

net-mgmt/net-snmp/Makefile
18

Are you positively *sure* this will work ?

ports-mgmt/pkg/Makefile
67

That was WITH_PKGNG and nobody ever saw it ?

Mk/bsd.port.mk
4602

-a has to be removed

Mk/bsd.port.mk
1602

Nope but it was already ignored by pkg because @stopdaemon is wrong and dangerous

net-mgmt/net-snmp/Makefile
18

The behaviour is kept the same as before this patch, so if it worked until now, it will still work :)

ports-mgmt/pkg/Makefile
67

the requirement to install pkg with pkg_install was due to an old bug in pkg2ng fixed long ago it is not needed anymore

In D708#23, @bapt wrote:

Nope but it was already ignored by pkg because @stopdaemon is wrong and dangerous

Can you please add a few words about it to CHANGES?

Add a comment about @stopdaemon

This revision is now accepted and ready to land.Sep 1 2014, 12:43 PM

Committed as rP366875: Remove support for pkg_install