Page MenuHomeFreeBSD

net/libvncserver: Update to 0.9.10
ClosedPublic

Authored by woodsb02 on Jun 23 2016, 8:49 PM.

Details

Summary

net/libvncserver: Update to 0.9.10

  • Change from SF to GITHUB, as old WWW redirects there
  • Add USES=autoreconf pkgconfig as distfile no longer contains configure
  • Remove CONFIGURE_ARGS=--without-x as it is ignored (no longer supported)
  • Convert OPENSSL and GNUTLS to OPTIONS_SINGLE, as build fails with neither
  • Add GNUTLS_IMPLIES=GCRYPT as build fails with GNUTLS but not GCRYPT
  • Add LIB_DEPENDS=libgpg-error.so as reported by new stage-qa script
  • Tidy up patches to match new release

Reported by: dutchman01@quicknet.nl
Release notes: https://github.com/LibVNC/libvncserver/releases/tag/LibVNCServer-0.9.10

Test Plan

poudriere bulk -t \
net/libvncserver \
emulators/aqemu \
emulators/kcemu \
emulators/virtualbox-ose \
net/krdc \
net/remmina-plugin-vnc

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

woodsb02 updated this revision to Diff 17831.Jun 23 2016, 8:49 PM
woodsb02 retitled this revision from to net/libvncserver: Update to 0.9.10.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, mat, koobs.
woodsb02 updated this object.Jun 23 2016, 8:51 PM
woodsb02 updated this object.Jun 23 2016, 8:53 PM
adamw added inline comments.Jun 23 2016, 9:21 PM
net/libvncserver/files/patch-Makefile.am
8 ↗(On Diff #17831)

Instead of this, do:

PATHFIX_MAKEFILEIN=    Makefile.am

By default, Uses/pathfix.mk alters Makefile.in. By switching to USES=autoreconf, you need to tell it to alter Makefile.am rather than Makefile.in, which either doesn't exist or gets overwritten.

adamw added inline comments.Jun 23 2016, 9:22 PM
net/libvncserver/Makefile
30 ↗(On Diff #17831)

Is gcrypt usable with OpenSSL? I thought they were, in general, mutually exclusive?

woodsb02 added a subscriber: brnrd.Jun 23 2016, 9:24 PM
mat added inline comments.Jun 23 2016, 9:41 PM
net/libvncserver/files/patch-Makefile.am
8 ↗(On Diff #17831)
woodsb02 updated this revision to Diff 17850.Jun 24 2016, 9:08 AM

As per comments from adamw and mat, remove patch for Makefile.am and
instead adapt pathfix to correct pkgconfig directory in Makefile.am

woodsb02 marked 2 inline comments as done.Jun 24 2016, 9:10 AM
woodsb02 added inline comments.Jun 24 2016, 9:14 AM
net/libvncserver/Makefile
30 ↗(On Diff #17831)

I am not particularly familiar with this, but it builds fine with both OPENSSL and GCRYPT options enabled (with GNUTLS option disabled). In fact, comparing the libraries built when using the OPENSSL option, with and without the GNUTLS option, the libraries link against the following additional libraries with GNUTLS enabled:

+       libgcrypt.so.20 => /usr/local/lib/libgcrypt.so.20 (0x80246b000)
+       libgpg-error.so.0 => /usr/local/lib/libgpg-error.so.0 (0x80277d000)
+       libintl.so.8 => /usr/local/lib/libintl.so.8 (0x802bb9000)

So it appears that it both builds ok with OPENSSL and GCRYPT, and also links to additional libraries. Happy to take direction here as to whether this should be changed.

mat accepted this revision.Jun 24 2016, 9:30 AM
mat edited edge metadata.

Macro stlgtm:

net/libvncserver/Makefile
25 ↗(On Diff #17850)

Try to keep the variables related to USES just below the USES line :-)

This revision is now accepted and ready to land.Jun 24 2016, 9:30 AM
This revision was automatically updated to reflect the committed changes.
woodsb02 marked an inline comment as done.Jun 24 2016, 9:48 AM