net/libvncserver: Update to 0.9.10

[woodsb02]

Summary

net/libvncserver: Update to 0.9.10

• Change from SF to GITHUB, as old WWW redirects there
• Add USES=autoreconf pkgconfig as distfile no longer contains configure
• Remove CONFIGURE_ARGS=--without-x as it is ignored (no longer supported)
• Convert OPENSSL and GNUTLS to OPTIONS_SINGLE, as build fails with neither
• Add GNUTLS_IMPLIES=GCRYPT as build fails with GNUTLS but not GCRYPT
• Add LIB_DEPENDS=libgpg-error.so as reported by new stage-qa script
• Tidy up patches to match new release

Reported by: [e-mail]
Release notes: https://github.com/LibVNC/libvncserver/releases/tag/LibVNCServer-0.9.10

Test Plan

poudriere bulk -t \
net/libvncserver \
emulators/aqemu \
emulators/kcemu \
emulators/virtualbox-ose \
net/krdc \
net/remmina-plugin-vnc

[adamw]

net/libvncserver/files/patch-Makefile.am

8 ↗

(On Diff #17831)

Instead of this, do:

PATHFIX_MAKEFILEIN=    Makefile.am

By default, Uses/pathfix.mk alters Makefile.in. By switching to USES=autoreconf, you need to tell it to alter Makefile.am rather than Makefile.in, which either doesn't exist or gets overwritten.

[adamw]

net/libvncserver/Makefile

30 ↗

(On Diff #17831)

Is gcrypt usable with OpenSSL? I thought they were, in general, mutually exclusive?

[mat]

net/libvncserver/files/patch-Makefile.am

8 ↗

(On Diff #17831)

Exactly what https://www.freebsd.org/doc/en/books/porters-handbook/uses-pathfix.html says :-)

[woodsb02]

As per comments from adamw and mat, remove patch for Makefile.am and
instead adapt pathfix to correct pkgconfig directory in Makefile.am

[woodsb02]

net/libvncserver/Makefile

30 ↗

(On Diff #17831)

I am not particularly familiar with this, but it builds fine with both OPENSSL and GCRYPT options enabled (with GNUTLS option disabled). In fact, comparing the libraries built when using the OPENSSL option, with and without the GNUTLS option, the libraries link against the following additional libraries with GNUTLS enabled:

+       libgcrypt.so.20 => /usr/local/lib/libgcrypt.so.20 (0x80246b000)
+       libgpg-error.so.0 => /usr/local/lib/libgpg-error.so.0 (0x80277d000)
+       libintl.so.8 => /usr/local/lib/libintl.so.8 (0x802bb9000)

So it appears that it both builds ok with OPENSSL and GCRYPT, and also links to additional libraries. Happy to take direction here as to whether this should be changed.

[mat]

net/libvncserver/Makefile

25 ↗

(On Diff #17850)

Try to keep the variables related to USES just below the USES line :-)