posixshm: Fix lock leak when mac_posixshm_check_read rejects read.
ClosedPublic
Actions

Authored by jilles on Jun 22 2016, 9:57 PM.

Details

Reviewers

kib
jhb
rwatson

Commits

rS302151: posixshm: Fix lock leak when mac_posixshm_check_read rejects read.

Summary

While reading the code, I noticed that shm_read() returns without
unlocking foffset and rangelock if mac_posixshm_check_read() rejects the
read.

Test Plan

cd /usr/tests/sys/posixshm && kyua test

I did not actually test with a real MAC module.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jilles updated this revision to Diff 17779.Jun 22 2016, 9:57 PM

jilles retitled this revision from to posixshm: Fix lock leak when mac_posixshm_check_read rejects read..

jilles updated this object.

jilles edited the test plan for this revision. (Show Details)

jilles added reviewers: kib, rwatson.

Herald added a subscriber: imp. · View Herald TranscriptJun 22 2016, 9:57 PM

kib accepted this revision.Jun 23 2016, 6:31 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2016, 6:31 AM

This change seems sensible to me, but I believe John has worked with this code most recently, so I've added him as a reviewer as well.

The read bits are Konstantin's code, so his review counts for more weight than mine. This looks good to me though.

Closed by commit rS302151: posixshm: Fix lock leak when mac_posixshm_check_read rejects read. (authored by jilles). · Explain WhyJun 23 2016, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

uipc_shm.c

6 lines

Diff 17832

View Options

posixshm: Fix lock leak when mac_posixshm_check_read rejects read.ClosedPublicActions