Page MenuHomeFreeBSD

sfxge(4): handle negative ticks difference correctly
ClosedPublic

Authored by arybchik on Jun 8 2016, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 8:02 AM
Unknown Object (File)
Fri, Nov 1, 10:00 AM
Unknown Object (File)
Oct 3 2024, 9:18 AM
Unknown Object (File)
Sep 29 2024, 11:25 PM
Unknown Object (File)
Sep 18 2024, 8:37 AM
Unknown Object (File)
Jun 1 2024, 11:12 PM
Unknown Object (File)
May 18 2024, 3:06 AM
Unknown Object (File)
Apr 29 2024, 9:59 PM
Subscribers

Details

Summary

ticks are signed int and if statistics is not updated for a long time
(more than INT_MAX ticks, but less than UINT_MAX) difference becomes
negative and less than hz for a long time.

Other option to repeat is simply load driver (which initializes
timestamps to 0) when ticks are negative.

Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

Module built, loaded, sysctl stats checked.
Stats tested on a lucky host with negative ticks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik retitled this revision from to sfxge(4): handle negative ticks difference correctly.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, bz, np.
This revision was automatically updated to reflect the committed changes.