Page MenuHomeFreeBSD

Mk/Uses/xfce.mk
AbandonedPublic

Authored by rene on Aug 23 2014, 3:33 PM.

Details

Reviewers
bapt
olivierd
Group Reviewers
portmgr
xfce
Summary

For the next stable release (4.12) I would like to replace Mk/bsd.xfce.mk file by Mk/Uses/xfce.mk.

In Xfce repository trunk branch already uses it.

Now, dependencies are well detected.

Usage is USES= xfce or USES= xfce:gtk3

gtk3 is necessary because some applications (Mousepad, xfce4-appfinder, xfce4-panel) support Gtk3 (optional), whereas it's mandatory in Parole. We need to test, if Gtk3 has been enabled in x11/libxfce4menu.

I also added warning message, when port uses libgui (x11-toolkits/libxfce4gui) because this library is not anymore maintained by upstream, and requires patch due changes in x11/libxfce4util.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

olivierd retitled this revision from to Mk/Uses/xfce.mk.
olivierd updated this object.
olivierd edited the test plan for this revision. (Show Details)

The Xfce page enumerates new ports (compatible with old Mk/bsd.xfce.mk and new one Mk/Uses/xfce.mk.

antoine added inline comments.
Mk/Uses/xfce.mk
88

Using post-install target for this is not good, if the port already has one only the 1st one will be used

Also I'm not sure a target for this is good, maybe should be a

DEPRECATED?= Depends on unmaintained x11-toolkits/libxfce4gui
Mk/bsd.port.mk
1912

I believe this part doesn't work

If you have to define some things after post.mk, Uses/xfce.mk has to look like this:

.if !defined(_INCLUDE_USES_XFCE_MK)
_INCLUDE_USES_XFCE_MK=yes

put here things to be defined before post.mk

_USES_POST+=xfce
.endif

.if defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_XFCE_POST_MK)
_INCLUDE_USES_XFCE_POST_MK=yes

put here things to be defined after post.mk

.endif
bapt requested changes to this revision.Oct 16 2014, 8:00 AM
bapt added a reviewer: bapt.
bapt added a subscriber: bapt.

Can you change according to my comments and @antoine's comments

Mk/Uses/xfce.mk
93

You can avoid using a target by defining

WARNING= "" \
                  "WARNING: ${.CURDIR:S/${PORTSDIR}\///} depends of x11-toolkits/libxfce4gui," \
                  "which is not anymore maintained by upstream."
                  ""
This revision now requires changes to proceed.Oct 16 2014, 8:00 AM
In D677#6, @bapt wrote:

Can you change according to my comments and @antoine's comments

Sorry for delay, below new one:

you can update the review with arc diff --update D677 Mk/Uses/xfce.mk that would be easier to review :)

rene added a reviewer: olivierd.

Abandoning this revision, it has been committed in r380565