amd64 pmap_change_attr(): avoid spurious EINVAL.
ClosedPublic
Actions

Authored by kib on Jun 1 2016, 2:25 AM.

Details

Reviewers

alc
jhb
mav

Commits

rS301457: Avoid spurious EINVAL in amd64 pmap_change_attr().

Summary

Do not try to change attributes for DMAP when working on a mapping which is not covered by the DMAP. This was reported on real system where a BAR of a device (NTB) was mapped outside the PCI window.

Reported and tested by: mav

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib updated this revision to Diff 17166.Jun 1 2016, 2:25 AM

kib retitled this revision from to amd64 pmap_change_attr(): avoid spurious EINVAL..

kib updated this object.

kib edited the test plan for this revision. (Show Details)

kib added reviewers: jhb, alc, mav.

kib set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2016, 2:25 AM

Looks good and fixes EINVAL errors for me.

This revision is now accepted and ready to land.Jun 1 2016, 3:07 AM

Note that ntb(4) should be changed to use bus_map_resource() and stop using pmap_change_attr() directly in 11 but that is orthogonal to this.

Closed by commit rS301457: Avoid spurious EINVAL in amd64 pmap_change_attr(). (authored by kib). · Explain WhyJun 5 2016, 5:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

pmap.c

11 lines

Diff 17332

View Options

head/sys/amd64/amd64/pmap.c

amd64 pmap_change_attr(): avoid spurious EINVAL.ClosedPublicActions