[BHND] (fix) set of corrections

[mizhka]

Summary

Hi,

This patch contains following fixes:

• [bus] default implementation of get_attach_type should iterate over device tree before panic. May be it worth to implement it only for BHND(4) bus (bcma / siba).
• [chipc] correct IRQ lines for UART (to fix IRQ lookup in future)
• [chipc] check device unit in resource assignment during chipc_add_child
• [chipc] if hint->size is RM_MAX_END, resource end should be same as window end
• [chipc] clear reference from resource list entry to resource in case of resource release
• [chipc] add get_caps implementation
• [chipc] correct flash constants (to be unshifted)
• [chipc] def implementation for BHND_CHIPC_GET_CAPS inside bhnd_chipc_if.m

Test Plan

Tested on ASUS RT-N53, ASUS RT-N16

[mizhka]

• fixed merge issue to head

[landon_landonf.org]

Looks good, just some minor comments inlined.

sys/dev/bhnd/bhnd_bus_if.m

59 ↗

(On Diff #16947)

For consistency with the other bhnd_bus_generic_ methods (and symbol accessibility), this should be lifted out into bhnd.h and bhnd_subr.c.

sys/dev/bhnd/cores/chipc/chipc.c

491 ↗

(On Diff #16947)

To avoid any confusion between unit and dunit, I suggest overwriting unit with the assigned value.

492 ↗

(On Diff #16947)

The returned unit should never be -1 here, but this highlights an issue on non-SoC bhnd(4) devices; since unit numbers aren't local to a bus, they may already be claimed elsewhere.

To still support the use of 0-relative unit numbers in the hints table, I think something like this should work (just before hint matching):

busrel_unit = 0;
for (int i = 0; i < unit; i++) {
      if (device_find_child(dev, name, i) != NULL)
                busrel_unit++;
}

[mizhka]

• fixed review remarks
• added default implementation for get_caps method to allow all devices in hierarchy under CC to access ChipCommon capabilities
• additional testing (RT-N16)

[landon_landonf.org]

Other than some minor style(9) issues to be fixed, looks good to me. Thanks for fixing these!

sys/dev/bhnd/cores/chipc/bhnd_chipc_if.m

42 ↗

(On Diff #16990)

Minor style(9) issue, the * should be adjoining the function name.

sys/dev/bhnd/cores/chipc/chipc.c

1282 ↗

(On Diff #16990)

style(9), should be space between chipc_caps and *

[mizhka]

• fixed style(9) issues

[mizhka]

• move def implementation for BHND_CHIPC_GET_CAPS into bhnd_chipc_if.m