Page MenuHomeFreeBSD
Differential D6563

Remove FreeBSD-specific float ABI selection for arm from Clang
Needs ReviewPublic
Actions

Authored by jkim on May 25 2016, 10:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 11:16 AM
Unknown Object (File)
Nov 19 2024, 6:18 PM
Unknown Object (File)
Oct 21 2024, 7:17 AM
Unknown Object (File)
Oct 4 2024, 4:42 AM
Unknown Object (File)
Sep 30 2024, 3:45 PM
Unknown Object (File)
Sep 23 2024, 7:37 PM
Unknown Object (File)
Sep 8 2024, 7:19 AM
Unknown Object (File)
Sep 7 2024, 2:54 PM
View All 60 Files
Subscribers
None

Details

Reviewers
dim
andrew
imp
Summary

arm defaults to hard float since r300119. This patch removes a FreeBSD-specific code from Clang.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jkim updated this revision to Diff 16879.May 25 2016, 10:25 PM
jkim retitled this revision from to Remove FreeBSD-specific float ABI selection for arm from Clang.
jkim updated this object.
jkim edited the test plan for this revision. (Show Details)
jkim added reviewers: imp, dim, andrew.
jkim set the repository for this revision to rS FreeBSD src repository - subversion.
dim edited edge metadata.May 26 2016, 6:56 AM

Hmm, if arm on FreeBSD 10.x and earlier still uses this selection, I would rather put in a major OS version check. This way, we can send this change upstream without modification, and it will work correctly also for out-of-tree clang (which, at some point, is going to be the default).

jkim updated this revision to Diff 16933.May 26 2016, 6:48 PM
jkim edited edge metadata.

For FreeBSD 10 and earlier, use soft float.

dim accepted this revision.May 26 2016, 8:14 PM
dim edited edge metadata.

This way it looks fine to me. I will submit it upstream too.

This revision is now accepted and ready to land.May 26 2016, 8:14 PM
andrew edited edge metadata.May 27 2016, 9:15 AM

The default ABI prior to armv6 should still be soft, this seems to change it to softfp. There is also no reason to not default to softfp on armv6 on 10.

jkim updated this revision to Diff 16998.May 27 2016, 4:07 PM
jkim edited edge metadata.
This revision now requires review to proceed.May 27 2016, 4:07 PM
dim added a comment.Aug 22 2016, 7:24 PM

@andrew, does this cover all cases correctly now? I'll submit it upstream then, after comitting into our tree.

imp edited edge metadata.Aug 22 2016, 10:25 PM

This looks good, modulo the 10.x comments...

Revision Contents
Changeset List

PathSize
contrib/
llvm/
tools/
clang/
lib/
Driver/
18 lines

Diff 16933

View Options

contrib/llvm/tools/clang/lib/Driver/Tools.cpp

Loading...