Page MenuHomeFreeBSD

Remove FreeBSD-specific float ABI selection for arm from Clang
Needs ReviewPublic

Authored by jkim on May 25 2016, 10:25 PM.

Details

Reviewers
dim
andrew
imp
Summary

arm defaults to hard float since r300119. This patch removes a FreeBSD-specific code from Clang.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jkim retitled this revision from to Remove FreeBSD-specific float ABI selection for arm from Clang.
jkim updated this object.
jkim edited the test plan for this revision. (Show Details)
jkim added reviewers: imp, dim, andrew.
jkim set the repository for this revision to rS FreeBSD src repository - subversion.

Hmm, if arm on FreeBSD 10.x and earlier still uses this selection, I would rather put in a major OS version check. This way, we can send this change upstream without modification, and it will work correctly also for out-of-tree clang (which, at some point, is going to be the default).

jkim edited edge metadata.

For FreeBSD 10 and earlier, use soft float.

dim edited edge metadata.

This way it looks fine to me. I will submit it upstream too.

This revision is now accepted and ready to land.May 26 2016, 8:14 PM

The default ABI prior to armv6 should still be soft, this seems to change it to softfp. There is also no reason to not default to softfp on armv6 on 10.

jkim edited edge metadata.
This revision now requires review to proceed.May 27 2016, 4:07 PM

@andrew, does this cover all cases correctly now? I'll submit it upstream then, after comitting into our tree.

This looks good, modulo the 10.x comments...