Use reallocf instead of malloc to fix leak with outbuf_pmap

[ngie]

Summary

Use reallocf instead of malloc to fix leak with outbuf_pmap

The previous code overwrote outbuf_pmap's memory with malloc once per
loop iteration, which leaked its memory; use reallocf instead to ensure
that memory is properly free'd each loop iteration.

Add a outbuf_pmap = NULL in the failure case to avoid a double-free
at the bottom of the function.

Reported by: Coverity
CID: 1038776
MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

[pfg]

Interesting. Looks good to me.

[markj]

Looks ok to me from a correctness perspective.

lib/libc/rpc/clnt_bcast.c

350

The line break is kind of ugly. Maybe make the assignment and check separate statements?

351

We appear to already free outbuf_pmap at done_broad, so I don't see the need for reallocf()+pointer clear vs. just a realloc() call.

[ngie]

lib/libc/rpc/clnt_bcast.c

351

I agree in theory, but replacing realloc with reallocf would require adding more complexity to deal with temporary pointers and the like. This is a pretty easy way to do things, even if it duplicates in the pathological case..

[markj]

lib/libc/rpc/clnt_bcast.c

351

Ok, I see what you mean. Ignore what I said.