sfxge(4): only raise an exception after MC assert or reboot in the common code
ClosedPublic
Actions

Authored by arybchik on May 16 2016, 9:19 AM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS300011: sfxge(4): only raise an exception after MC assert or reboot in the common code

Summary

Fix efx_mcdi_request_poll so it only raises an exception if EIO is
reported from a detected MC assert or reboot. This prevents
an unnecessary exception being raised if an MCDI response error
code is trandlated to EIO.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

tinderbox amd64 kernels build sanity checked

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 16387.May 16 2016, 9:19 AM

arybchik retitled this revision from to sfxge(4): only raise an exception after MC assert or reboot in the common code.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptMay 16 2016, 9:19 AM

Closed by commit rS300011: sfxge(4): only raise an exception after MC assert or reboot in the common code (authored by arybchik). · Explain WhyMay 17 2016, 6:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

efx_mcdi.c

9 lines

Diff 16448

View Options

head/sys/dev/sfxge/common/efx_mcdi.c

sfxge(4): only raise an exception after MC assert or reboot in the common codeClosedPublicActions