New port: astro/weewx

[asomers]

Summary

Open source software for your weather station

Test Plan

I built, installed, and ran it on 10.2 and head. I ran portlint and
rclint. I uninstalled it and checked that no turds remained. I have
not tested every feature of the software. I have not built it with
poudriere.

This is my first port in several years, so I probably made some
mistakes.

[asomers]

astro/weewx/Makefile

14

Yes, configobj really is required at buildtime. weewx tries to be much too smart in setup.py

22

I could've made an option knob for pyephem. But I didn't bother because pyephem is pretty small and has no dependencies besides python itself.

35

ports complains that "PYDISTUTILS_INSTALLNOSINGLE is deprecated", but weewx won't build without it and I couldn't figure out any alternative. Is there some newer way to get the functionality of PYDISTUTILS_INSTALLNOSINGLE?

37

I could've named the service weewx instead of weewxd. But I settled on weewxd because the package contains other executables besides just the daemon. I could be convinced otherwise.

astro/weewx/files/patch-setup.py

2

All the crap in this file is to make weewx work with staging. It's so "smart" that it edits paths inside of several files during "setup.py install"

astro/weewx/pkg-plist

2

I didn't put the rc script inside of pkg-plist. pkg seems to figure that out on its own. Is that right?

[asomers]

Fix the font paths

[asomers]

Use @sample in the pkg-plist instead of pkg-message

[swills]

See inline comments. Overall, nice work!

astro/weewx/Makefile

12

Please specify LICENSE_FILE

45–46

Seems silly to loop over 2 things, turning 2 lines into 5, but not a huge deal

astro/weewx/distinfo

2

Missing TIMESTAMP

astro/weewx/pkg-plist

2

rc script is added to plist by USE_RC_SUBR

3

Please use PORTDOCS for README

[asomers]

Apply swills's comments. Use PORTDOCS and LICENSE_FILE, and regenerate
distinfo with TIMESTAMP fields.

[asomers]

astro/weewx/pkg-plist

3

Should I also use it for all the stuff under weewx/docs?

[brd]

I would guess that the rest of the stuff under docs should not be PORTDOCS, since it is mostly HTML and that is how the app will be accessed.

[asomers]

astro/weewx/Makefile

18

I few days ago py-imaging was removed from the ports tree. I need to change this to pillow and retest the port.

[asomers]

Fix the py-imaging problem, update to 3.6.0, and fix a few other minor issues

[asomers]

Upstream has reved the package and disappeared the original distfile. I need to update the port to 3.6.2 and try again.

[brd]

Also run it through Poudriere testport :)

[asomers]

Update to 3.6.2. Fix the mysql dependency. Add NO_ARCH.

[brd]

astro/weewx/Makefile

9

s/freebsd/FreeBSD

[brd]

astro/weewx/Makefile

29

No MYSQL_DESC= ?

Just curious, what would mysql support add?

[asomers]

astro/weewx/Makefile

29

MYSQL allows you to store the archive data in a mysql database. The default is sqlite.

[asomers]

Correct email capitalization

[mat]

astro/weewx/Makefile

29

There already is a MYSQL_DESC.

48–50

Using only one sed on setup.py would be better, something like:

@${REINPLACE_CMD} -e 's:%%STAGEDIR%%:${STAGEDIR}:g; s,%%PREFIX%%,${PREFIX},g' \

${WRKSRC}/setup.p

49–53

It wuld be simpler to not patch the files and simply replace /usr/local with PREFIX or LOCALBASE depending on which file is used.

astro/weewx/pkg-descr

2–7

Does it have a web site, if yes, add WWW: http://... as the last line here.

astro/weewx/pkg-plist

145–148

unless it breaks the application, please move the documentation to DOCSDIR.

[asomers]

astro/weewx/Makefile

49–53

I can do this for setup.cfg and the font files, but not for setup.py. That file's patch is more complicated than a simple search and replace; it's fixing the fact that the installer wants to write the STAGEDIR into a config file.

astro/weewx/pkg-plist

145–148

Will do.

[asomers]

Respond to mat's comments and add an EXAMPLES option