Differential D6311

Allwinner add H3 support
ClosedPublic
Actions

Authored by manu on May 10 2016, 7:04 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Apr 26, 10:37 PM

	Unknown Object (File)
	Fri, Apr 26, 10:59 AM

	Unknown Object (File)
	Thu, Apr 25, 11:05 PM

	Unknown Object (File)
	Mar 20 2024, 10:20 AM

	Unknown Object (File)
	Dec 20 2023, 1:49 AM

	Unknown Object (File)
	Nov 28 2023, 8:15 PM

	Unknown Object (File)
	Nov 28 2023, 6:27 PM

	Unknown Object (File)
	Nov 27 2023, 8:31 PM

View All 40 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS299688: Add support for Allwinner H3 SoC.

Summary

Add H3 support.
For now SMP, EHCI GPIO and pinctrl, this is what's it described in the DTS.

Test Plan

Tested on Orange Pi One.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu updated this revision to Diff 16154.May 10 2016, 7:04 PM

manu retitled this revision from to Allwinner add H3 support.

manu updated this object.

manu edited the test plan for this revision. (Show Details)

manu added a reviewer: ARM.

manu set the repository for this revision to rS FreeBSD src repository - subversion.

manu added a project: ARM.

Herald added subscribers: loos, andrew, imp. · View Herald TranscriptMay 10 2016, 7:04 PM

jmcneill accepted this revision.May 10 2016, 7:59 PM

jmcneill added a reviewer: jmcneill.

jmcneill added a subscriber: jmcneill.

jmcneill added inline comments.

sys/arm/allwinner/clk/aw_pll.c
467 ↗	(On Diff #16154)	Can you add A23_PLL1_FACTOR_M/K/N defines so you're not referring to A31 stuff here? I know it's redundant but it makes it a bit easier when glancing at the code that there isn't a typo.
600 ↗	(On Diff #16154)	I suppose these should be sorted by compat string and not the data column.

This revision is now accepted and ready to land.May 10 2016, 7:59 PM

manu added inline comments.May 10 2016, 8:09 PM

sys/arm/allwinner/clk/aw_pll.c
467 ↗	(On Diff #16154)	Maybe a comment would do the job then ? I'm not really ok for adding duplicate defines ...
600 ↗	(On Diff #16154)	Tomato, Potato (c) Fez. But yeah I see your point, I'll change that.

Add defines for A23 PLLs so it's less confusing.

This revision now requires review to proceed.May 10 2016, 9:14 PM

manu marked 4 inline comments as done.May 10 2016, 9:14 PM

jmcneill accepted this revision.May 10 2016, 9:17 PM

jmcneill edited edge metadata.

This revision is now accepted and ready to land.May 10 2016, 9:17 PM

Closed by commit rS299688: Add support for Allwinner H3 SoC. (authored by manu). · Explain WhyMay 13 2016, 6:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

allwinner/

1 line

10 lines

allwinner_machdep.h

1 line

allwinner_machdep.c

24 lines

1 line

1 line

clk/

3 lines

31 lines

6 lines

h3/

4 lines

147 lines

60 lines

15 lines

1 line

conf/

1 line

conf/

1 line

Diff 16302

head/sys/arm/allwinner/a10_ehci.c

Loading...

head/sys/arm/allwinner/a10_gpio.c

Loading...

head/sys/arm/allwinner/allwinner_machdep.h

Loading...

head/sys/arm/allwinner/allwinner_machdep.c

Loading...

head/sys/arm/allwinner/aw_ccu.c

Loading...

head/sys/arm/allwinner/aw_usbphy.c

Loading...

head/sys/arm/allwinner/clk/aw_gate.c

Loading...

head/sys/arm/allwinner/clk/aw_pll.c

Loading...

head/sys/arm/allwinner/clk/aw_usbclk.c

Loading...

head/sys/arm/allwinner/h3/files.h3

Loading...

head/sys/arm/allwinner/h3/h3_padconf.c

Loading...

head/sys/arm/allwinner/h3/h3_r_padconf.c

Loading...

head/sys/arm/allwinner/h3/std.h3

Loading...

head/sys/arm/allwinner/std.allwinner

Loading...

head/sys/arm/conf/ALLWINNER

Loading...

head/sys/conf/options.arm

Loading...