Page MenuHomeFreeBSD

net/opal: Fix build with ffmpeg 3.0.x
ClosedPublic

Authored by woodsb02 on May 10 2016, 5:34 PM.

Details

Reviewers
adamw
koobs
kwm
mat
Group Reviewers
gnome
Summary

net/opal: Fix build with ffmpeg 3.0.x

  • Add patch to allow opal to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.

PR: 209346
Reported by: antoine (PR207547)
Approved by: xxx (mentor)
Obtained from: ArchLinux [1]

[1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal
Test Plan

poudriere bulk -t \

net/opal
net-im/ekiga

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3680
Build 3723: arc lint + arc unit

Event Timeline

woodsb02 retitled this revision from to net/opal: Fix build with ffmpeg 3.0.x.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, koobs, mat.
adamw edited edge metadata.

If gnome@'s happy with it, then I am too.

This revision is now accepted and ready to land.May 10 2016, 5:37 PM
kwm added a reviewer: kwm.
kwm added a subscriber: kwm.

With my gnome@ hat

Macro lgtm:

woodsb02 edited edge metadata.

Committed here: r414950.

Not sure why phabricator did not automatically close this review.

Committed here: r414950.

Not sure why phabricator did not automatically close this review.

Because the diff revision line was not the last line of the commit message.

In D6308#134002, @mat wrote:

Committed here: r414950.

Not sure why phabricator did not automatically close this review.

Because the diff revision line was not the last line of the commit message.

Oh, ok. Thanks for the tip!