Page MenuHomeFreeBSD
Differential D6308

net/opal: Fix build with ffmpeg 3.0.x
ClosedPublic
Actions

Authored by woodsb02 on May 10 2016, 5:34 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Feb 2, 4:27 AM
Unknown Object (File)
Dec 15 2024, 9:40 PM
Unknown Object (File)
Dec 15 2024, 9:35 PM
Unknown Object (File)
Dec 15 2024, 9:34 PM
Unknown Object (File)
Nov 24 2024, 6:12 AM
Unknown Object (File)
Nov 23 2024, 10:33 AM
Unknown Object (File)
Nov 14 2024, 7:39 AM
Unknown Object (File)
Nov 10 2024, 5:49 PM
View All 92 Files
Subscribers
kwm

Details

Reviewers
adamw
koobs
kwm
mat
Group Reviewers
gnome
Summary

net/opal: Fix build with ffmpeg 3.0.x

  • Add patch to allow opal to build successfully once multimedia/ffmpeg is updated to 3.0.x. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.

PR: 209346
Reported by: antoine (PR207547)
Approved by: xxx (mentor)
Obtained from: ArchLinux [1]

[1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/opal-ffmpeg3.patch?h=packages/opal
Test Plan

poudriere bulk -t \

net/opal
net-im/ekiga

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3680
Build 3723: arc lint + arc unit

Event Timeline

woodsb02 updated this revision to Diff 16148.May 10 2016, 5:34 PM
woodsb02 retitled this revision from to net/opal: Fix build with ffmpeg 3.0.x.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, koobs, mat.
woodsb02 added a reviewer: gnome.May 10 2016, 5:35 PM
woodsb02 added a project: gnome.
adamw accepted this revision.May 10 2016, 5:37 PM
adamw edited edge metadata.

If gnome@'s happy with it, then I am too.

This revision is now accepted and ready to land.May 10 2016, 5:37 PM
kwm accepted this revision.May 10 2016, 5:43 PM
kwm added a reviewer: kwm.
kwm added a subscriber: kwm.

With my gnome@ hat

Macro lgtm:

woodsb02 updated this object.May 10 2016, 5:46 PM
woodsb02 edited edge metadata.
woodsb02 closed this revision.May 10 2016, 7:03 PM

Committed here: r414950.

Not sure why phabricator did not automatically close this review.

mat edited edge metadata.May 10 2016, 8:02 PM
In D6308#133954, @woodsb02 wrote:

Committed here: r414950.

Not sure why phabricator did not automatically close this review.

Because the diff revision line was not the last line of the commit message.

woodsb02 added a comment.May 10 2016, 8:03 PM
In D6308#134002, @mat wrote:
In D6308#133954, @woodsb02 wrote:

Committed here: r414950.

Not sure why phabricator did not automatically close this review.

Because the diff revision line was not the last line of the commit message.

Oh, ok. Thanks for the tip!

adamw added a comment.May 10 2016, 8:04 PM

TIL

Revision Contents
Changeset List

PathSize
net/
opal/
2 lines
files/
247 lines

Diff 16148

View Options

net/opal/Makefile

Loading...
View Options

net/opal/files/patch-ffmpeg3

Loading...