Page MenuHomeFreeBSD
Differential D6157

Uses/Mk/mysql.mk: Improve warning/error messages
Needs ReviewPublic
Actions

Authored by brnrd on Apr 30 2016, 9:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 10:54 PM
Unknown Object (File)
Sat, Sep 21, 12:48 PM
Unknown Object (File)
Sep 3 2024, 5:12 PM
Unknown Object (File)
Aug 21 2024, 6:10 PM
Unknown Object (File)
Aug 11 2024, 9:42 PM
Unknown Object (File)
Jul 29 2024, 1:37 PM
Unknown Object (File)
Jul 24 2024, 8:18 PM
Unknown Object (File)
Jul 24 2024, 4:44 PM
View All 34 Files
Subscribers
None

Details

Reviewers
feld
mat
koobs
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Proposed commit log

Uses/Mk/mysql.mk: Improve warning/error messages

  - Generate the actual package name for error messages
  - Add warning message when WITH_MYSQL_VER is set

Reviewed_by:	feld (mentor), koobs (mentor), mat (portmgr)
Approved by:	(mentor)
Differential_Revision:  D6157
Test Plan
  • Test with WITH_MYSQL_VER set
  • Test make in mariadb55-server with mariadb100-server installed

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5506
Build 5731: arc lint + arc unit

Event Timeline

brnrd updated this revision to Diff 15761.Apr 30 2016, 9:41 AM
brnrd retitled this revision from to Uses/Mk/mysql.mk: Improve warning/error messages.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: feld, koobs, mat.
Herald added a reviewer: portmgr. · View Herald TranscriptApr 30 2016, 9:41 AM
brnrd updated this object.Apr 30 2016, 9:41 AM
brnrd edited edge metadata.
mat added inline comments.Apr 30 2016, 11:24 AM
Mk/Uses/mysql.mk
57

Also add a "Support for WITH_MYSQL_VER will be removed on XXXX" in, say, like 3 months, at which time, it will be a .error

86–92

why not use the already existing _PERCONA and _MARIADB ?

Or rewrite the previous _PERCONA and _MARIADB to something more complex that will only set _MYSQL_FLAVOR.

brnrd updated this revision to Diff 15768.Apr 30 2016, 12:52 PM
brnrd marked 2 inline comments as done.

Note deprecation of DEFAULT_MYSQL_VER and WITH_MYSQL_VER in warning message

Herald edited edge metadata. · View Herald TranscriptApr 30 2016, 12:52 PM
brnrd added inline comments.Apr 30 2016, 12:53 PM
Mk/Uses/mysql.mk
57

Agree.
Taken the liberty to do the same for DEFAULT_MYSQL_VER.

86–92

There are no occurences of WITH_MYSQL_VER apart from Mk/Uses/mysql.mk in the ports tree.
_MYSQL_FLAVOUR relates to the currently installed version whereas _WITH_MYSQL_FLAVOUR relates to the global variable WITH_MYSQL_VER that is set by the user in /etc/make.conf.

mat added inline comments.May 2 2016, 1:14 PM
Mk/Uses/mysql.mk
54–55

You should use DEFAULT_VERSIONS+=foo

brnrd updated this revision to Diff 16003.May 6 2016, 10:05 PM
brnrd edited edge metadata.

Use += on DEFAULT_VERSIONS assigments

Herald edited edge metadata. · View Herald TranscriptMay 6 2016, 10:05 PM
brnrd marked an inline comment as done.May 6 2016, 10:06 PM
brnrd added inline comments.
Mk/Uses/mysql.mk
54–55

Done!

brnrd updated this revision to Diff 21167.EditedOct 7 2016, 9:01 PM
brnrd marked an inline comment as done.
brnrd edited edge metadata.

Rewrite _FLAVOUR to something more complex

  • Use :C/// modifiers to display correct error messages
  • Rework _MYSQL_FLAVOUR to use :C///
  • Use indentation on nested conditionals
  • Sort flavours alphabetically
Owners added a reviewer: O5: Ports Framework.Oct 7 2016, 9:01 PM
Herald edited edge metadata. · View Herald TranscriptOct 7 2016, 9:01 PM
mat added inline comments.Oct 12 2016, 10:39 AM
Mk/Uses/mysql.mk
54

This should be DEFAULT_VERSIONS+=

koobs resigned from this revision.May 7 2019, 5:13 AM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
65 lines

Diff 21167

View Options

Mk/Uses/mysql.mk

Loading...