Page MenuHomeFreeBSD
Differential D6151

PLATFORM arm honor hw.ncpu tunable
ClosedPublic
Actions

Authored by manu on Apr 29 2016, 4:06 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Nov 27, 9:35 AM
Unknown Object (File)
Oct 4 2024, 3:17 PM
Unknown Object (File)
Oct 3 2024, 7:12 PM
Unknown Object (File)
Oct 2 2024, 8:14 PM
Unknown Object (File)
Sep 29 2024, 6:01 PM
Unknown Object (File)
Sep 24 2024, 2:18 PM
Unknown Object (File)
Sep 24 2024, 3:53 AM
Unknown Object (File)
Sep 23 2024, 5:33 AM
View All 62 Files
Subscribers
andrew
imp
jmcneill

Details

Reviewers
andrew
Group Reviewers
ARM
Commits
rS299383: When PLATFORM_SMP is enabled, check if tunable hw.ncpu is set and valid
Summary

For PLATFORM setmaxid, check if tunable hw.ncpu is set and valid (>= 1 and <= real ncores) and set mp_ncpus to it.

Test Plan

Test on multicore PLATFORM-aware SMP board with different value of hw.ncpu set by ubldr.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu updated this revision to Diff 15736.Apr 29 2016, 4:06 PM
manu retitled this revision from to PLATFORM arm honor hw.ncpu tunable.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptApr 29 2016, 4:06 PM
jmcneill added a subscriber: jmcneill.Apr 29 2016, 6:07 PM

You should probably remove the (now redundant) hw.ncpu handling in arm/freescale/imx/imx6_mp.c and arm/altera/socfpga/socfpga_mp.c

manu added a comment.Apr 29 2016, 6:14 PM
In D6151#130965, @jmcneill wrote:

You should probably remove the (now redundant) hw.ncpu handling in arm/freescale/imx/imx6_mp.c and arm/altera/socfpga/socfpga_mp.c

They haven't been converted to PLATFORM_SMP

jmcneill added a comment.Apr 29 2016, 6:32 PM
In D6151#130970, @manu wrote:

They haven't been converted to PLATFORM_SMP

Thanks, I missed that.

andrew accepted this revision.Apr 30 2016, 4:19 PM
andrew added a reviewer: andrew.

I have something similar in a larger patch that also looks at the DTB to see if it has any cpu nodes & used this to count the cpus.

This revision is now accepted and ready to land.Apr 30 2016, 4:19 PM
Closed by commit rS299383: When PLATFORM_SMP is enabled, check if tunable hw.ncpu is set and valid (authored by manu). · Explain WhyMay 10 2016, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
arm/
8 lines

Diff 16155

View Options

head/sys/arm/arm/platform.c

Loading...