Page MenuHomeFreeBSD
Differential D60843

Mk/Uses/cran.mk: Install into a work library, then copy to the stage tree
Needs ReviewPublic
Actions

Authored by dteske on Sun, Oct 18, 5:53 PM.
Tags
None
Referenced Files
F176516559: D60843.id.diff
Mon, Oct 19, 11:39 AM
F176489531: D60843.diff
Mon, Oct 19, 6:45 AM
F176479163: D60843.id190215.diff
Mon, Oct 19, 4:51 AM
F176473262: D60843.id190215.diff
Mon, Oct 19, 3:44 AM
F176463912: D60843.id190215.diff
Mon, Oct 19, 1:42 AM
F176463256: D60843.diff
Mon, Oct 19, 1:33 AM
F176460481: D60843.diff
Mon, Oct 19, 1:01 AM
F176460018: D60843.id.diff
Mon, Oct 19, 12:56 AM
View All 11 Files
Subscribers
eduardo
mat

Details

Reviewers
fuz
jrm
uzsolt
Group Reviewers
portmgr
Summary

The source install writes Built: and is the build. A second install of
that directory is a binary copy into STAGEDIR. The source install needs
Depends, Imports, and LinkingTo on hand, so add RUN_DEPENDS to
BUILD_DEPENDS. A port with its own do-install keeps NO_BUILD.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78343
Build 75226: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Sun, Oct 18, 5:53 PM
dteske created this revision.
Harbormaster completed remote builds in B78343: Diff 190215.Sun, Oct 18, 5:53 PM
dteske mentioned this in D60835: */R-cran-*: Remove redundant BUILD_DEPENDS on other R-cran ports.Sun, Oct 18, 5:54 PM
eduardo added a subscriber: eduardo.Sun, Oct 18, 7:19 PM
jrm added inline comments.Sun, Oct 18, 10:33 PM
Mk/Uses/cran.mk
56

This will add run dependencies other than CRAN packages that might not be needed at build time. It's not catastrophic, but how about something like this?

mat added a subscriber: mat.Mon, Oct 19, 5:09 AM
mat added inline comments.
Mk/Uses/cran.mk
56

It's not really a problem, the dependencies will be installed anyway, they will simply be installed a little bit earlier with this.
And build depends are not registered in the package, so nothing really changes.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
28 lines

Diff 190215

View Options

Mk/Uses/cran.mk

Loading...