LinuxKPI: firmware: ensure name stays valid
Needs ReviewPublic
Actions

Authored by bz on Mon, Oct 12, 12:21 AM.

Tags

Referenced Files

	F175872953: D60630.id189539.diff
	Wed, Oct 14, 2:14 AM

	F175872116: D60630.diff
	Wed, Oct 14, 2:03 AM

	F175860497: D60630.diff
	Tue, Oct 13, 11:32 PM

	Unknown Object (File)
	Tue, Oct 13, 11:41 AM

	Unknown Object (File)
	Tue, Oct 13, 12:51 AM

	Unknown Object (File)
	Mon, Oct 12, 11:10 PM

	Unknown Object (File)
	Mon, Oct 12, 8:35 PM

	Unknown Object (File)
	Mon, Oct 12, 7:55 PM

View All 9 Files

Subscribers

emaste

imp

Details

Reviewers

None

Group Reviewers

linuxkpi

Summary

The name argument passed into request_firmware_nowait() may only be
valid locally in the calling function and could be out of scope by the
time the task runs; make a copy to ensure it stays valid over the
callback.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 78045
Build 74928: arc lint + arc unit

Event Timeline

bz created this revision.Mon, Oct 12, 12:21 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Oct 12, 12:21 AM

bz requested review of this revision.Mon, Oct 12, 12:21 AM

Harbormaster completed remote builds in B78045: Diff 189539.Mon, Oct 12, 12:21 AM

bz retitled this revision from LinuxKPI: firmware: ensure name stay valid to LinuxKPI: firmware: ensure name stays valid.Mon, Oct 12, 12:22 AM

bz added a child revision: D60632: LinuxKPI: add SPACEMIT PCI IDs.Tue, Oct 13, 10:25 PM

bz added a parent revision: D60245: LinuxKPI: rework cleanup.h to use CLASS.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_firmware.c

9 lines

Diff 189539

View Options

sys/compat/linuxkpi/common/src/linux_firmware.c

LinuxKPI: firmware: ensure name stays validNeeds ReviewPublicActions