Differential D60550

mgb: Correct TX interrupt bit
ClosedPublic
Actions

Authored by emaste on Fri, Oct 9, 7:15 PM.

Tags

None

Referenced Files

	F175307214: D60550.id189290.diff
	Fri, Oct 9, 8:19 PM

	F175306601: D60550.id189288.diff
	Fri, Oct 9, 8:13 PM

	F175306372: D60550.diff
	Fri, Oct 9, 8:10 PM

Subscribers

Details

Reviewers

br
kbowling
adrian

Commits

rG6c3f2b8be268: mgb: Correct TX interrupt bit

Summary

The TX interrupt handler checked MGB_INTR_STS_RX(qidx) instead of
MGB_INTR_STS_TX(qidx) -- presumably a copy-paste issue.

Because the driver does not use TX interrupts so there was no actual
issue in practice.

Fixes: 8890ab7758b8 ("Introduce if_mgb driver for Microchip LAN743x PCIe NIC")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Fri, Oct 9, 7:15 PM

emaste created this revision.

adrian accepted this revision.Fri, Oct 9, 7:19 PM

This revision is now accepted and ready to land.Fri, Oct 9, 7:19 PM

Closed by commit rG6c3f2b8be268: mgb: Correct TX interrupt bit (authored by emaste). · Explain WhyFri, Oct 9, 7:22 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG6c3f2b8be268: mgb: Correct TX interrupt bit.

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 9, 7:22 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mgb/

2 lines

Diff 189290

sys/dev/mgb/if_mgb.c

Loading...