mgb: support for PCI11414
Needs ReviewPublic
Actions

Authored by br on Fri, Oct 9, 4:56 PM.

Details

Reviewers

emaste

Group Reviewers

cheri

Summary

Add support for Microchip PCI11414 Gigabit Ethernet Controller.

The PCI11414 is used on the CHERI VITA 57.1 PCIe Extension Board.

Add PCI11414 device ID
Add support for SGMII mode. Read the programmed strap configuration and enable SGMII operation when configured. Bypass the MII interface in SGMII mode.
Support multiple packet segments in DMA descriptor rings.
Increase the timeout in mgb_wait_for_bits().
Increase the DMA descriptor ring size.

Test Plan

Tested on Codasip Prime platform synthesized on Xilinx VCU118.

Lint

Lint Skipped

Unit

Tests Skipped

br requested review of this revision.Fri, Oct 9, 4:56 PM

br created this revision.

br edited the summary of this revision. (Show Details)Fri, Oct 9, 4:57 PM

Style.

Overall looks good to me, a couple of inline questions and if feasible I'd like to see this as a few separate commits.

sys/dev/mgb/if_mgb.c
979	Can we split the multiseg change into a separate commit?
1219	Pre-existing, but perhaps worth printing `dev_id` here?
1494	This one reads more like a temporary debugging printf. I don't object, but could we perhaps extend it to something like "strap 0x## (SGMII_ENABLE)"?
1565	This increase is inconsistent with the comment above. Would you be so kind as to mention in a comment why this much larger delay is needed (and, commit it separately most likely).

sys/dev/mgb/if_mgb.c
470–471	The hard-coded up/1000Mbps should probably have a comment.
1013	Can we have a `#define` for this magic `0x04000000`
1565	Also, can we just increase `MGB_TIMEOUT` instead of increasing the delay per loop?