Page MenuHomeFreeBSD
Differential D6040

Optionally return the output capabilities list from _OSC.
ClosedPublic
Actions

Authored by jhb on Apr 21 2016, 7:43 AM.
Tags
None
Referenced Files
F110347216: D6040.diff
Mon, Feb 17, 3:53 AM
F110287082: D6040.id.diff
Sun, Feb 16, 6:50 AM
Unknown Object (File)
Jan 8 2025, 11:59 AM
Unknown Object (File)
Jan 1 2025, 11:44 PM
Unknown Object (File)
Nov 17 2024, 8:52 AM
Unknown Object (File)
Nov 17 2024, 5:33 AM
Unknown Object (File)
Nov 10 2024, 8:27 PM
Unknown Object (File)
Nov 10 2024, 7:13 AM
View All 57 Files
Subscribers
imp

Details

Reviewers
jkim
Commits
rS298484: Optionally return the output capabilities list from _OSC.
Summary

Optionally return the output capabilities list from _OSC.

Both of the callers were expecting the input cap_set to be modified.
This fixes them to request cap_set to be updated with the returned buffer.

Test Plan
  • booted on my laptop (has both PCI and CPU _OSC methods)
  • I added extra debugging to print out the _OSC status, returned buffer length and first word.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 15427.Apr 21 2016, 7:43 AM
jhb retitled this revision from to Optionally return the output capabilities list from _OSC..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: jkim.
Herald added a subscriber: imp. · View Herald TranscriptApr 21 2016, 7:43 AM
jkim accepted this revision.Apr 21 2016, 6:54 PM
jkim edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2016, 6:54 PM
jkim added inline comments.Apr 21 2016, 7:03 PM
sys/dev/acpica/acpi_pcib_acpi.c
328 ↗(On Diff #15427)

Please remove this redundant return statement while you're at it.

jhb marked an inline comment as done.Apr 22 2016, 5:50 PM
Closed by commit rS298484: Optionally return the output capabilities list from _OSC. (authored by jhb). · Explain WhyApr 22 2016, 5:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
acpica/
28 lines
4 lines
6 lines
3 lines

Diff 15508

View Options

head/sys/dev/acpica/acpi.c

Loading...
View Options

head/sys/dev/acpica/acpi_cpu.c

Loading...
View Options

head/sys/dev/acpica/acpi_pcib_acpi.c

Loading...
View Options

head/sys/dev/acpica/acpivar.h

Loading...