Don't leak fd on sectorsize malloc failure

[ngie]

Summary

Don't leak fd on sectorsize malloc failure

Also, call endfsent after calling getfsent for code cleanliness

CID: 1354785
X-MFC with: r298076
Reported by: Coverity
Sponsored by: EMC / Isilon Storage Division

[cem]

sbin/savecore/savecore.c

843–848

If my reading of getfsent(3) is correct (endfsent() 1:1 with getfsent()), we should call endfsent() before continue in the !swap && !dump case as well.

[ngie]

Move endfsent call outside the loop

It should only be called once

[ngie]

sbin/savecore/savecore.c

843–848

It should have been outside the for (;;) loop -- good catch!

[cem]

In D6014#128089, @ngie wrote:

Move endfsent call outside the loop

It should only be called once

Are you sure about that? The man page is pretty unclear to me.

[cem]

Ok, you're right per the implementation.

[ngie]

In D6014#128094, @cem wrote:

In D6014#128089, @ngie wrote:

Move endfsent call outside the loop

It should only be called once

Are you sure about that? The man page is pretty unclear to me.

Yeah... the cobwebs I dusted off had to deal with using the API back in my Linux days.. had to deal with perl IIRC *shudders*...