Page MenuHomeFreeBSD
Differential D60043

cuse: Assert the server refcount
Needs ReviewPublic
Actions

Authored by christos on Sat, Sep 26, 1:25 PM.
Tags
None
Referenced Files
F173721540: D60043.id187740.diff
Sun, Sep 27, 10:58 PM
F173719529: D60043.diff
Sun, Sep 27, 10:40 PM
F173689798: D60043.id187740.diff
Sun, Sep 27, 6:16 PM
F173668054: D60043.diff
Sun, Sep 27, 2:35 PM
Unknown Object (File)
Sat, Sep 26, 9:25 PM
Unknown Object (File)
Sat, Sep 26, 6:56 PM
Unknown Object (File)
Sat, Sep 26, 2:27 PM
Unknown Object (File)
Sat, Sep 26, 2:24 PM
Subscribers
imp

Details

Reviewers
markj
emaste
kib
Summary

Assert that the refcount does not underflow before decrementing it, and
that it really is zero by the time the server is freed.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77406
Build 74289: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Sep 26, 1:25 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 26, 1:25 PM
christos requested review of this revision.Sat, Sep 26, 1:25 PM
Harbormaster completed remote builds in B77351: Diff 187740.Sat, Sep 26, 1:25 PM
kib accepted this revision.Sun, Sep 27, 9:20 PM
This revision is now accepted and ready to land.Sun, Sep 27, 9:20 PM
christos retitled this revision from cuse: Assert that the server refcount does not underflow to cuse: Assert the server refcount.Mon, Sep 28, 10:34 AM
christos edited the summary of this revision. (Show Details)
christos updated this revision to Diff 187865.Mon, Sep 28, 10:35 AM

Assert that ref == 0 when the server is freed.

This revision now requires review to proceed.Mon, Sep 28, 10:35 AM
Harbormaster completed remote builds in B77406: Diff 187865.Mon, Sep 28, 10:36 AM
christos mentioned this in D59872: cuse: Improve server cleanup.Mon, Sep 28, 10:36 AM

Revision Contents
Changeset List

PathSize
sys/
fs/
cuse/
2 lines

Diff 187865

View Options

sys/fs/cuse/cuse.c

Loading...