Page MenuHomeFreeBSD

acpi_timer: Trim some more leftovers from the ACPI-safe timer
AcceptedPublic

Authored by jhb on Wed, Sep 23, 7:02 PM.
Tags
None
Referenced Files
F173196651: D59933.id.diff
Thu, Sep 24, 5:55 AM
F173165815: D59933.diff
Thu, Sep 24, 1:35 AM
F173150130: D59933.id187523.diff
Wed, Sep 23, 11:01 PM
F173149609: D59933.diff
Wed, Sep 23, 10:56 PM
Subscribers

Details

Reviewers
cperciva
olce
Summary

The "safe" variant of the hook to read the timer is no longer used and
can be removed. Instead, initialize the get_timecount member of
acpi_timer_timecounter to the normal hook statically. While here,
initialize a few more fields in acpi_timer_timecounter statically.
I've kept the name as just "ACPI" instead of "ACPI-fast" now.

During device probe there is no longer any reason to alloc the
register resource since it is not used, so remove all that. While
here, defer registration of the timecounter until attach (kind of odd
to do such a thing during probe leaving a window where the timer
register was unallocated but in theory could still be read via the
timecounter).

Fixes: 00d061855deb ("Garbage-collect ACPI-safe timer and friends")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77215
Build 74098: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Wed, Sep 23, 7:02 PM

LGTM! I'm not entirely sure why I didn't do this a couple years ago. Maybe I was leaving bits in the tree so they would be visible in case of MFCs?

This revision is now accepted and ready to land.Wed, Sep 23, 7:32 PM