cuse: Use make_dev_s() to create client devices
ClosedPublic
Actions

Authored by christos on Mon, Sep 21, 12:27 PM.

Details

Reviewers

markj
emaste
kib

Commits

rG1c6b48130d9a: cuse: Use make_dev_s() to create client devices
rGfad756fd200b: cuse: Use make_dev_s() to create client devices

Summary

make_dev_s() sets si_drv1 before the node is published in devfs, which
avoids a race where cuse_client_open() could see it as NULL. It also now
reports finer-grained errors on failure, instead of only ENOMEM.

While here, drop the NULL checks on kern_dev in cuse_server_free_dev(),
since a device is only added to the server's list once it has been
created.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Mon, Sep 21, 12:27 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 21, 12:27 PM

christos requested review of this revision.Mon, Sep 21, 12:27 PM

christos mentioned this in D59872: cuse: Improve server cleanup.Mon, Sep 21, 12:27 PM

Harbormaster completed remote builds in B77136: Diff 187328.Mon, Sep 21, 12:28 PM

kib accepted this revision.Mon, Sep 21, 6:22 PM

This revision is now accepted and ready to land.Mon, Sep 21, 6:22 PM

Closed by commit rGfad756fd200b: cuse: Use make_dev_s() to create client devices (authored by christos). · Explain WhyWed, Sep 30, 9:51 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGfad756fd200b: cuse: Use make_dev_s() to create client devices.

christos added a commit: rG1c6b48130d9a: cuse: Use make_dev_s() to create client devices.Wed, Oct 7, 6:25 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

cuse/

cuse.c

26 lines

Diff 188172

View Options

cuse: Use make_dev_s() to create client devicesClosedPublicActions