Page MenuHomeFreeBSD

cuse: Use make_dev_s() to create client devices
AcceptedPublic

Authored by christos on Mon, Sep 21, 12:27 PM.
Tags
None
Referenced Files
F172898039: D59874.diff
Mon, Sep 21, 10:38 PM
F172894748: D59874.diff
Mon, Sep 21, 10:09 PM
F172894544: D59874.diff
Mon, Sep 21, 10:07 PM
Subscribers

Details

Reviewers
markj
emaste
kib
Summary

make_dev_s() sets si_drv1 before the node is published in devfs, which
avoids a race where cuse_client_open() could see it as NULL. It also now
reports finer-grained errors on failure, instead of only ENOMEM.

While here, drop the NULL checks on kern_dev in cuse_server_free_dev(),
since a device is only added to the server's list once it has been
created.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77136
Build 74019: arc lint + arc unit