Page MenuHomeFreeBSD

cuse: Create /dev/cuse with MAKEDEV_CHECKNAME
ClosedPublic

Authored by christos on Sun, Sep 20, 5:02 PM.
Tags
None
Referenced Files
F176148266: D59863.diff
Fri, Oct 16, 12:17 PM
Unknown Object (File)
Thu, Oct 15, 3:06 AM
Unknown Object (File)
Thu, Oct 15, 1:20 AM
Unknown Object (File)
Mon, Oct 12, 6:58 AM
Unknown Object (File)
Sat, Oct 10, 2:59 PM
Unknown Object (File)
Wed, Oct 7, 11:38 AM
Unknown Object (File)
Wed, Oct 7, 8:53 AM
Unknown Object (File)
Wed, Oct 7, 7:06 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/fs/cuse/cuse.c
278–281

But now cuse_dev could be NULL. At very least, destroy_dev() should check that the cdev node was created.

sys/fs/cuse/cuse.c
278–281

It is checked already in cuse_kern_uninit(), no?

	if (cuse_dev != NULL)
		destroy_dev(cuse_dev);
sys/fs/cuse/cuse.c
278–281

I guess we could also make cuse_kern_init() return an int and propagate this back to cuse_modevent(), if needed. What do you think?

sys/fs/cuse/cuse.c
278–281

Sorry, ok. But if you cannot fail the module load, perhaps the printf() below should indicate a failure to create /dev/cuse instead of the path.

christos marked 2 inline comments as done.

Address Konstanin's comments.

This revision is now accepted and ready to land.Sun, Sep 20, 5:28 PM