Page MenuHomeFreeBSD

cuse: Create /dev/cuse with MAKEDEV_CHECKNAME
AcceptedPublic

Authored by christos on Sun, Sep 20, 5:02 PM.
Tags
None
Referenced Files
F173295366: D59863.diff
Fri, Sep 25, 2:01 AM
F173252814: D59863.diff
Thu, Sep 24, 5:41 PM
F173241879: D59863.id187296.diff
Thu, Sep 24, 3:09 PM
Unknown Object (File)
Mon, Sep 21, 11:48 AM
Unknown Object (File)
Mon, Sep 21, 10:18 AM
Unknown Object (File)
Mon, Sep 21, 1:55 AM
Unknown Object (File)
Mon, Sep 21, 1:54 AM
Unknown Object (File)
Mon, Sep 21, 1:46 AM
Subscribers

Details

Reviewers
markj
emaste
kib
Summary

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77122
Build 74005: arc lint + arc unit

Event Timeline

sys/fs/cuse/cuse.c
278–281

But now cuse_dev could be NULL. At very least, destroy_dev() should check that the cdev node was created.

sys/fs/cuse/cuse.c
278–281

It is checked already in cuse_kern_uninit(), no?

	if (cuse_dev != NULL)
		destroy_dev(cuse_dev);
sys/fs/cuse/cuse.c
278–281

I guess we could also make cuse_kern_init() return an int and propagate this back to cuse_modevent(), if needed. What do you think?

sys/fs/cuse/cuse.c
278–281

Sorry, ok. But if you cannot fail the module load, perhaps the printf() below should indicate a failure to create /dev/cuse instead of the path.

christos marked 2 inline comments as done.

Address Konstanin's comments.

This revision is now accepted and ready to land.Sun, Sep 20, 5:28 PM