Page MenuHomeFreeBSD
Differential D5982

bhyve: document signals handling and exit codes
ClosedPublic
Actions

Authored by novel on Apr 17 2016, 3:55 AM.
Tags
None
Referenced Files
F89391364: D5982.id.diff
Sat, Jul 27, 10:54 AM
Unknown Object (File)
Tue, Jul 23, 2:25 AM
Unknown Object (File)
Mon, Jul 22, 9:43 PM
Unknown Object (File)
Sun, Jul 14, 4:40 AM
Unknown Object (File)
Wed, Jul 10, 11:17 PM
Unknown Object (File)
Wed, Jul 10, 10:59 PM
Unknown Object (File)
Wed, Jul 10, 10:07 PM
Unknown Object (File)
Wed, Jul 10, 9:54 PM
View All 61 Files
Subscribers
imp
wblock

Details

Reviewers
grehan
neel
wblock
Group Reviewers
Doc Committers
manpages
Commits
rS298341: Update the bhyve(8) man page:
Summary

Update the bhyve(8) man page:

  • Document powering off by sending SIGTERM signal
  • Document exit codes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

novel updated this revision to Diff 15273.Apr 17 2016, 3:55 AM
novel retitled this revision from to bhyve: document signals handling and exit codes.
novel updated this object.
novel edited the test plan for this revision. (Show Details)
novel added reviewers: neel, grehan, Doc Committers.
novel set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: manpages. · View Herald TranscriptApr 17 2016, 3:55 AM
Herald added a subscriber: imp. · View Herald Transcript
wblock added a subscriber: wblock.Apr 17 2016, 4:42 PM
wblock added inline comments.
usr.sbin/bhyve/bhyve.8
302 ↗(On Diff #15273)

How about a shorter version:

Exit status indicates how the VM was terminated:
310 ↗(On Diff #15273)

"VM was" in these three entries is redundant and can just be eliminated entirely.

312 ↗(On Diff #15273)

s/Triple/triple/ to match the other entries.

wblock added a comment.Apr 17 2016, 4:44 PM

Oh, and remember to update .Dd. Nice to routinely run igor -R bhyve.8 and mandoc -Tlint bhyve.8 before commit, too.

novel updated this revision to Diff 15285.Apr 18 2016, 7:33 AM
novel edited edge metadata.
  • Updated wording
  • Updated .Dd
Herald edited edge metadata. · View Herald TranscriptApr 18 2016, 7:33 AM
novel marked 3 inline comments as done.Apr 18 2016, 7:33 AM
wblock accepted this revision.Apr 18 2016, 7:02 PM
wblock added a reviewer: wblock.

Thanks!

This revision is now accepted and ready to land.Apr 18 2016, 7:02 PM
novel added a comment.Apr 19 2016, 4:14 AM
In D5982#127617, @wblock wrote:

Thanks!

Thank you for review, Warren. Does that mean that I, as a ports committer, can commit it?

neel accepted this revision.Apr 19 2016, 6:11 PM
neel edited edge metadata.
wblock added a comment.Apr 20 2016, 4:21 AM
In D5982#127701, @novel wrote:
In D5982#127617, @wblock wrote:

Thanks!

Thank you for review, Warren. Does that mean that I, as a ports committer, can commit it?

I usually think of accepting a review as separate from an "Approved-by", but I'll give an Approved-by for this. Remember to enter that on the commit.

Closed by commit rS298341: Update the bhyve(8) man page: (authored by novel). · Explain WhyApr 20 2016, 6:29 AM
This revision was automatically updated to reflect the committed changes.
novel mentioned this in rS298341: Update the bhyve(8) man page:.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
23 lines

Diff 15374

View Options

head/usr.sbin/bhyve/bhyve.8

Loading...