Differential D59816

vmm: Re-arm the PIT callout for square wave mode
ClosedPublic
Actions

Authored by hayzam_gmail.com on Fri, Sep 18, 5:04 PM.

Tags

None

Referenced Files

	F173733891: D59816.id187118.diff
	Mon, Sep 28, 12:46 AM

	F173730848: D59816.diff
	Mon, Sep 28, 12:19 AM

	F173699660: D59816.id187345.diff
	Sun, Sep 27, 7:52 PM

	Unknown Object (File)
	Sat, Sep 26, 10:18 PM

	Unknown Object (File)
	Sat, Sep 26, 11:08 AM

	Unknown Object (File)
	Sat, Sep 26, 9:13 AM

	Unknown Object (File)
	Sat, Sep 26, 9:07 AM

	Unknown Object (File)
	Sat, Sep 26, 3:50 AM

View All 30 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGfc44154841fc: vmm: Re-arm the PIT callout for square wave mode

Summary

The 8254's square wave mode (mode 3) is periodic, with the same
interrupt rate as the rate generator mode (mode 2), but
vatpit_callout_handler() only re-arms the channel 0 callout for
TIMER_RATEGEN. A guest that programs mode 3 therefore receives a
single IRQ0 and no further timer interrupts.

Re-arm the callout for TIMER_SQWAVE as well, matching illumos
change 13301.

Obtained from: illumos 93d78aba5b32996fc2ae893a6237a0d3972f86b2
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hayzam_gmail.com created this revision.Fri, Sep 18, 5:04 PM

Herald added a reviewer: bhyve. · View Herald TranscriptFri, Sep 18, 5:04 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

hayzam_gmail.com requested review of this revision.Fri, Sep 18, 5:04 PM

Harbormaster completed remote builds in B77061: Diff 187118.Fri, Sep 18, 5:04 PM

markj accepted this revision as: markj.Fri, Sep 18, 8:43 PM

This revision is now accepted and ready to land.Fri, Sep 18, 8:43 PM

Closed by commit rGfc44154841fc: vmm: Re-arm the PIT callout for square wave mode (authored by hayzam_gmail.com, committed by markj). · Explain WhyMon, Sep 21, 4:42 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfc44154841fc: vmm: Re-arm the PIT callout for square wave mode.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

io/

2 lines

Diff 187345

sys/amd64/vmm/io/vatpit.c

Loading...