Paths

Table of Contentst

Differential D59602

pciconf: Add -C option to filter by class name
ClosedPublic
Actions

Authored by code_fedang.net on Fri, Sep 11, 10:16 PM.

Tags

None

Referenced Files

	F175084997: D59602.id186782.diff
	Thu, Oct 8, 3:59 AM

	Unknown Object (File)
	Fri, Oct 2, 7:03 PM

	Unknown Object (File)
	Fri, Oct 2, 6:54 PM

	Unknown Object (File)
	Fri, Oct 2, 5:15 PM

	Unknown Object (File)
	Fri, Oct 2, 4:37 PM

	Unknown Object (File)
	Thu, Oct 1, 7:32 AM

	Unknown Object (File)
	Tue, Sep 29, 9:40 PM

	Unknown Object (File)
	Tue, Sep 29, 8:34 PM

View All 73 Files

Subscribers

Details

Reviewers

Commits

rG46d383af0dbd: pciconf: Add -C option to filter by class name

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

code_fedang.net created this revision.Fri, Sep 11, 10:16 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Sep 11, 10:16 PM

code_fedang.net requested review of this revision.Fri, Sep 11, 10:16 PM

Harbormaster completed remote builds in B76785: Diff 186493.Fri, Sep 11, 10:16 PM

Use strcasecmp instead of strcmp to check class name.

Harbormaster completed remote builds in B76786: Diff 186494.Fri, Sep 11, 10:27 PM

Addresses Bug 289923

bnovkov added inline comments.Mon, Sep 14, 4:44 PM

usr.sbin/pciconf/pciconf.8
26	Please bump the date.
usr.sbin/pciconf/pciconf.c
1101	This function should ideally return a `bool`.
1104
1107	Please turn this into an explicit `== 0` check
1108–1111

Address comment

Harbormaster completed remote builds in B76936: Diff 186782.Tue, Sep 15, 3:46 PM

code_fedang.net marked 5 inline comments as done.Tue, Sep 15, 4:18 PM

bnovkov added inline comments.Fri, Sep 18, 9:24 AM

usr.sbin/pciconf/pciconf.c
335	Passing `-l` without a class string will crash the program since there's no `class != NULL` check here or in `validate_class`. I suggest adding a NULL check in `validate_class`.

Fix null check

Harbormaster completed remote builds in B77072: Diff 187182.Fri, Sep 18, 11:20 PM

code_fedang.net marked an inline comment as done.Fri, Sep 18, 11:21 PM

code_fedang.net added inline comments.

usr.sbin/pciconf/pciconf.c
335	oops, that slipped through

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 21, 6:39 PM

Closed by commit rG46d383af0dbd: pciconf: Add -C option to filter by class name (authored by code_fedang.net, committed by bnovkov). · Explain Why

This revision was automatically updated to reflect the committed changes.

bnovkov added a commit: rG46d383af0dbd: pciconf: Add -C option to filter by class name.

Revision Contents
Changeset List

Path

Size

usr.sbin/

pciconf/

10 lines

40 lines

Diff 187352

usr.sbin/pciconf/pciconf.8

Loading...

usr.sbin/pciconf/pciconf.c

Loading...