Fix fmaf(3) sw implementation for subnormals
ClosedPublic
Actions

Authored by kib on Thu, Sep 10, 11:38 PM.

Details

Reviewers

fuz
kfv

Commits

rGb08e6a3882b4: lib/msun: use the same algorithm for sw fmaf(3) as for fma(3)
rGcb82cc9f0e3b: lib/msun: add tests for fmaf(3) subnormals

Summary

lib/msun: use the same algorithm for sw fmaf(3) as for fma(3)

This fixes rounding at the last bit for subnormals.


lib/msun: add tests for fmaf(3) subnormals

PR:     298260

(The author is set to 'kargl@')

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Thu, Sep 10, 11:38 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 10, 11:38 PM

kib requested review of this revision.Thu, Sep 10, 11:38 PM

kib edited the summary of this revision. (Show Details)

This is above my paygrade as far as numerical programming goes, but let's just hope it's fine.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 11, 5:53 PM

Closed by commit rGcb82cc9f0e3b: lib/msun: add tests for fmaf(3) subnormals (authored by Steve Kargl <kargl@FreeBSD.org>, committed by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGcb82cc9f0e3b: lib/msun: add tests for fmaf(3) subnormals.

kib added a commit: rGb08e6a3882b4: lib/msun: use the same algorithm for sw fmaf(3) as for fma(3).

Revision Contents
Changeset List

Path

Size

lib/

msun/

tests/

fma_test.c

28 lines

Diff 186475

View Options

Fix fmaf(3) sw implementation for subnormalsClosedPublicActions