if_bnxt: add support for SIOCGI2CPB page/bank i2c requests
AcceptedPublic
Actions

Authored by sumit.saxena_broadcom.com on Thu, Sep 10, 2:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 4, 1:06 AM

	Unknown Object (File)
	Sat, Oct 3, 2:55 PM

	Unknown Object (File)
	Tue, Sep 29, 4:40 PM

	Unknown Object (File)
	Tue, Sep 29, 4:40 PM

	Unknown Object (File)
	Mon, Sep 28, 10:48 PM

	Unknown Object (File)
	Mon, Sep 28, 12:00 PM

	Unknown Object (File)
	Thu, Sep 24, 9:51 PM

	Unknown Object (File)
	Wed, Sep 23, 11:32 PM

View All 14 Files

Subscribers

None

Details

Reviewers

gallatin
sreekanth.reddy_broadcom.com
shurd

Summary

Advertise IFLIB_I2C_PAGE_BANK and forward the requested page/bank to
firmware, so CMIS optics can be read correctly instead of falling
back to bogus legacy SFF-8472 decoding. Also fix bnxt_i2c_req() to
return positive errno values.

Signed-off-by: gallatin@netflix.com

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sumit.saxena_broadcom.com created this revision.Thu, Sep 10, 2:40 PM

Herald added a reviewer: shurd. · View Herald TranscriptThu, Sep 10, 2:40 PM

sumit.saxena_broadcom.com requested review of this revision.Thu, Sep 10, 2:40 PM

gallatin added inline comments.Thu, Sep 10, 2:55 PM

sys/dev/bnxt/bnxt_en/if_bnxt.c
5143	This one line is plenty. Please delete the rest of the comment
5152–5160	Seems more like a review from an llm than a code comment. Please shorten it to one line or remove it.