Page MenuHomeFreeBSD

cam (mmc): only report 1.8V signaling once the bus has switched
Needs ReviewPublic

Authored by seuros on Mon, Aug 31, 12:07 AM.
Tags
None
Referenced Files
F169124264: D59283.id185463.diff
Mon, Aug 31, 12:08 PM
F169123390: D59283.diff
Mon, Aug 31, 12:01 PM
F169106519: D59283.id185463.diff
Mon, Aug 31, 10:37 AM
F169071461: D59283.id.diff
Mon, Aug 31, 8:07 AM
F169058921: D59283.diff
Mon, Aug 31, 7:16 AM
F169017994: D59283.id185463.diff
Mon, Aug 31, 3:27 AM
F168987583: D59283.diff
Mon, Aug 31, 1:46 AM
Subscribers

Details

Reviewers
adrian
bz
imp
Group Reviewers
ARM
cam
Summary

On a host that advertises no 1.8V capability the voltage switch is never
attempted, yet the feature was still recorded and the card announce line
claimed 1.8V signaling while the bus stayed at 3.3V.

Set the feature only after the tran settings change requesting vccq_180 has
completed successfully, so that it describes the signaling level in use rather
than what the card offered. A host that cannot switch, or failure
now leaves the bus at 3.3V.

Test Plan

Observed in Raspberry Pi2/3/5

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76341
Build 73224: arc lint + arc unit

Event Timeline

I believe this is wrong. The 18V here is a card *feature* and the feature doesn't change with what the host supports.

The actual voltage of the bus, if I remember correctly, is in ios.vccq.

You could cross check that with camcontrol.