Page MenuHomeFreeBSD

openssh: Update to 10.5p1
Needs ReviewPublic

Authored by emaste on Tue, Aug 25, 1:47 PM.
Tags
None
Referenced Files
F169776890: D59172.diff
Wed, Sep 2, 1:07 PM
F169554011: D59172.diff
Tue, Sep 1, 9:57 PM
Unknown Object (File)
Tue, Sep 1, 2:01 PM
Unknown Object (File)
Tue, Sep 1, 11:35 AM
Unknown Object (File)
Tue, Sep 1, 1:47 AM
Unknown Object (File)
Sun, Aug 30, 1:21 PM
Unknown Object (File)
Sun, Aug 30, 1:06 AM
Unknown Object (File)
Sat, Aug 29, 11:30 PM
Subscribers

Details

Reviewers
jlduran
bdrewery
Summary

This is a diff against upstream 10.5p1 after the update

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Do you think I can commit D52203 after you commit this update, or maybe incorporate those changes here?
The changes from freebsd-configure.sh (config.h) and freebsd-namespace.sh (ssh_namespace.h) are in a separate commit as usual?
I have this change in libssh's Makefile:

--- a/secure/lib/libssh/Makefile
+++ b/secure/lib/libssh/Makefile
@@ -35,7 +35,7 @@ SRCS= ${LIBOPENSSH_SRCS} \
        libcrux-mlkem-mldsa.c ssh-mldsa-eddsa.c \
        hmac.c ed25519.c ed25519-openssl.c \
        kex.c kex-names.c kexdh.c kexgex.c kexecdh.c kexc25519.c \
-       kexgexc.c kexgexs.c \
+       kexgexc.c kexgexs.c kexmlkem768ecdh.c \
        kexsntrup761x25519.c kexmlkem768x25519.c sntrup761.c kexgen.c \
        sftp-realpath.c platform-pledge.c platform-tracing.c platform-misc.c \
        sshbuf-io.c misc-agent.c ssherr-libcrypto.c
servconf.c
326

I think you should commit D52203 now, I will rebase this change after.

I have this change in libssh's Makefile:

Yeah, I just grabbed the diff between crypto/openssh and upstream for this phab diff. secure/lib/libssh/Makefile has your change.

I think you should commit D52203 now, I will rebase this change after.

Done!

servconf.c
253

I'll try to submit this defaultkey check/patch, while preparing the patch, I wonder if we should use strcmp(3) instead (given my other suggestion change below):

if (file != NULL && strcmp(file, defaultkey) == 0 &&
    access(apath, R_OK) != 0) {