Differential D59144

install: Fix two bugs in stdin code
Needs ReviewPublic
Actions

Authored by des on Mon, Aug 24, 2:00 PM.

Details

Reviewers

siva

Summary

Fix case where the source is - and the target exists.

Only call chflags() (to remove flags that might prevent us from replacing an existing target) in the exists case; otherwise, to_sb.st_flags is uninitialized.

Rename the source file in the stdin test case.

Extend null and stdin test cases to cover the case where the target already exists.

PR: 297681
MFC after: 1 week
Fixes: d34870708db9 ("install: Allow installing stdin")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76160
Build 73043: arc lint + arc unit

Event Timeline

des created this revision.Mon, Aug 24, 2:00 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Aug 24, 2:00 PM

des requested review of this revision.Mon, Aug 24, 2:00 PM

Harbormaster completed remote builds in B76049: Diff 184885.Mon, Aug 24, 2:00 PM

des edited the summary of this revision. (Show Details)Mon, Aug 24, 2:16 PM

update

Harbormaster completed remote builds in B76050: Diff 184886.Mon, Aug 24, 2:17 PM

des edited the summary of this revision. (Show Details)Mon, Aug 24, 2:17 PM

drop second exists test

Harbormaster completed remote builds in B76160: Diff 185092.Tue, Aug 25, 5:41 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

xinstall/

tests/

install_test.sh

24 lines

xinstall.c

6 lines

Diff 185092

View Options

usr.bin/xinstall/tests/install_test.sh