Page MenuHomeFreeBSD
Differential D5906

[amd64] dtrace_invop handler is to be called only for kernel exceptions
ClosedPublic
Actions

Authored by avg on Apr 11 2016, 7:36 AM.
Tags
None
Referenced Files
F168749192: D5906.id15065.diff
Sat, Aug 29, 11:12 PM
Unknown Object (File)
Sat, Aug 29, 5:58 AM
Unknown Object (File)
Thu, Aug 27, 4:48 AM
Unknown Object (File)
Thu, Aug 13, 9:04 PM
Unknown Object (File)
Thu, Aug 13, 12:33 PM
Unknown Object (File)
Wed, Aug 12, 12:01 AM
Unknown Object (File)
Tue, Aug 11, 10:22 AM
Unknown Object (File)
Tue, Aug 11, 10:02 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
jhb
Commits
rS297846: [amd64] dtrace_invop handler is to be called only for kernel exceptions
Summary

DTrace-related exceptions in userland code are handled elsewhere.
One practical problem was a crash in dtrace_invop_start() when saved
%rsp pointed to a virtual address that was not backed.

i386 code already ignored userland exceptions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg updated this revision to Diff 15065.Apr 11 2016, 7:36 AM
avg retitled this revision from to [amd64] dtrace_invop handler is to be called only for kernel exceptions.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: jhb, kib, markj.
Herald added a subscriber: imp. · View Herald TranscriptApr 11 2016, 7:36 AM
markj accepted this revision.Apr 11 2016, 7:54 AM
markj edited edge metadata.

Looks reasonable to me, thanks.

This revision is now accepted and ready to land.Apr 11 2016, 7:54 AM
kib accepted this revision.Apr 11 2016, 8:09 AM
kib edited edge metadata.
Closed by commit rS297846: [amd64] dtrace_invop handler is to be called only for kernel exceptions (authored by avg). · Explain WhyApr 12 2016, 6:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines

Diff 15094

View Options

head/sys/amd64/amd64/exception.S

Loading...