Differential D5894

Replace zero with NULL for pointers in ixl driver
ClosedPublic
Actions

Authored by pfg on Apr 9 2016, 5:11 PM.

Details

Reviewers

erj

Group Reviewers

Intel Networking

Commits

rS297753: ixl(4): replace 0 with NULL for pointers.

Summary

I have been playing with coccinelle (http://coccinelle.lip6.fr/), and it found some cases where 0 is being used and we should be using NULL instead.
I have many more changes, this only cover the ones in sys/dev/ixl

Test Plan

This doesn't break the build.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

pfg updated this revision to Diff 15042.Apr 9 2016, 5:11 PM

pfg retitled this revision from to Replace zero with NULL for pointers in ixl driver.

pfg updated this object.

pfg edited the test plan for this revision. (Show Details)

pfg added a reviewer: erj.

pfg set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: Intel Networking. · View Herald TranscriptApr 9 2016, 5:11 PM

Herald added a subscriber: imp. · View Herald Transcript

Looks completely valid to me.

This revision is now accepted and ready to land.Apr 9 2016, 5:28 PM

Closed by commit rS297753: ixl(4): replace 0 with NULL for pointers. (authored by pfg). · Explain WhyApr 9 2016, 5:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

if_ixl.c

4 lines

if_ixlv.c

2 lines

Diff 15042

View Options

sys/dev/ixl/if_ixl.c